Notifications.Windows.SetReadyCallbackStatus success rate is a bit low |
|||
Issue descriptionThis metric checks several prerequisites for Win10 native notification: shortcut configuration, COM server configuration, and COM initialization. Although the metric is skewed a bit now (and needs to be fixed), its success rate is less than 99%. For these users, their notifications will fall back to the non-native ones. This needs more investigation. NOTE: this metric has been depreciated and replaced with Notifications.Windows.SetReadyCallbackStatus2
,
Jun 4 2018
,
Jun 5 2018
After fixing the skewed metric, here is the metric: The success rate (Canary, June 4th) is 98.43%. The major failure reason is mis-configuration of shortcut (10X of COM server mis-configuration). I suspect this is simply due to shortcut missing (e.g., deleted by the user). I am adding Notifications.Windows.StartMenuShortStatus metric to confirm.
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45ba979168c8b938da7ce898b8cd389da90f798b commit 45ba979168c8b938da7ce898b8cd389da90f798b Author: Xi Cheng <chengx@chromium.org> Date: Tue Jun 05 19:37:55 2018 Log Notifications.Windows.StartMenuShortStatus This metric gives more details about case SHORTCUT_MISCONFIGURATION of Notifications.Windows.SetReadyCallbackStatus. Bug: 847989 , 734095 Change-Id: I5be3de19807a18b4b5eb4520cabaf464ac4668d1 Reviewed-on: https://chromium-review.googlesource.com/1086187 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#564616} [modify] https://crrev.com/45ba979168c8b938da7ce898b8cd389da90f798b/chrome/installer/util/install_util.cc [modify] https://crrev.com/45ba979168c8b938da7ce898b8cd389da90f798b/tools/metrics/histograms/enums.xml [modify] https://crrev.com/45ba979168c8b938da7ce898b8cd389da90f798b/tools/metrics/histograms/histograms.xml
,
Jun 7 2018
As mentioned in comment 3, the mis-configuration of shortcut is the major reason for the failures (i.e., roll back to the non-native notification system). The new metric Notifications.Windows.StartMenuShortStatus as in comment 4 showed that ~70% of shortcut mis-configuration cases are shortcut missing and ~30% are due to incorrect toast activator CLSID. The check of toast activator CLSID involves a bunch of Windows API operations. While I can use another metric to look into the CLSID issue, I prefer to stop the efforts as it is only 0.4% of all cases. The shortcut is re-installed during every update which makes this issue a less concern. I am going to mark this issue as fixed for now.
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a881cd8db7591b0fc042148f38fc5e8ae25b598 commit 6a881cd8db7591b0fc042148f38fc5e8ae25b598 Author: Xi Cheng <chengx@chromium.org> Date: Mon Jun 11 22:51:12 2018 Fix typo in Notifications.Windows.StartMenuShortStatus metric's name The correct name is Notifications.Windows.StartMenuShortcutStatus Bug: 847989 Change-Id: I212b4003e76cbf03c294fa6b20b0b4de5250a4ba Reviewed-on: https://chromium-review.googlesource.com/1095544 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#566183} [modify] https://crrev.com/6a881cd8db7591b0fc042148f38fc5e8ae25b598/chrome/installer/util/install_util.cc [modify] https://crrev.com/6a881cd8db7591b0fc042148f38fc5e8ae25b598/tools/metrics/histograms/enums.xml [modify] https://crrev.com/6a881cd8db7591b0fc042148f38fc5e8ae25b598/tools/metrics/histograms/histograms.xml |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 1 2018