Issue metadata
Sign in to add a comment
|
0.2% regression in sizes at 562189:562189 |
||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 30 2018
Assigning to sheriff gbiv@chromium.org because this autoroll is the only CL in range: Roll AFDO from 69.0.3442.0_rc-r1 to 69.0.3443.0_rc-r1 This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ieb0519d501547be5273367f91aca9f8d747980ed Reviewed-on: https://chromium-review.googlesource.com/1074927 Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562189}
,
May 30 2018
Hm. So it looks like this is a new increase, but the roll in r562349 saved us 0.4% of our binary size, which appears to bring the binary size penalty of AFDO to less than what it was when we launched it (?). I've yet to hear any perf-related yelling about r562349. Assuming it's not a garbage profile (which I've only seen a few of since we started doing AFDO 5 months ago on Android...), it'd be interesting to see what about 3444 is keeping size down. (We have a higher-level goal of trying to figure out whether AFDO is worth it for Linux when it hits the stable channel. I'll keep this open as a reminder until then, and/or as a note in case I start seeing way more AFDO-caused volatility in binary size on Linux) |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, May 30 2018