New issue
Advanced search Search tips

Issue 847980 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 12
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Autofill dropdown looks too close to the input element

Project Member Reported by ftirelo@chromium.org, May 30 2018

Issue description

Chrome Version: M68+
OS: desktop

The autofill dropdown looks too close to the input element (see screenshots attached). We should add a space between the element and the dropdown. Discussing with rfeng@, 1px is enough.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1c12e6636c8e39757b366441e26710666059776

commit f1c12e6636c8e39757b366441e26710666059776
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Wed Jun 20 21:23:56 2018

[af] Adjust dropdown so it doesn't look so close to the input element

Bug:  847980 
Change-Id: I3000a303d016d68dc86a21211399bc24c204a8a0
Reviewed-on: https://chromium-review.googlesource.com/1080689
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569022}
[modify] https://crrev.com/f1c12e6636c8e39757b366441e26710666059776/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
CL was reverted to make it easier to revert a more complex CL that introduced a crash on Canary. Reopening the bug.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03daf4e42f99ef9329ec05fc186c1936ffa718a9

commit 03daf4e42f99ef9329ec05fc186c1936ffa718a9
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Thu Jul 12 19:22:00 2018

Reland: [af] Adjust dropdown so it doesn't look so close to the input element

This relands commit f1c12e6, which was reverted by commit c71c2c1.

The reason for the revert was a crash introduced by c53515c, and
reverting that commit was very hard due to merge conflicts.

Bug:  847980 
Change-Id: Ib1b6931d3ac697e78c27a6cbcc7e082f0da4b6ef
Reviewed-on: https://chromium-review.googlesource.com/1135446
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574676}
[modify] https://crrev.com/03daf4e42f99ef9329ec05fc186c1936ffa718a9/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc

Status: Fixed (was: Assigned)

Sign in to add a comment