New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 847969 link

Starred by 2 users
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Jun 2018
Cc:
dpa...@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Settings: logic for lock-screen password input not behaving as expected

Project Member Reported by scottchen@chromium.org, May 30 2018 
The UI is not behaving as expected (based on comment in code).

Repro:
1) Open ChromeOS
2) Go to chrome://settings
3) go to lock-screen, observe a dialog prompting for password appears
4) type an incorrect password
5) submit. Observe that the input is invalid and shows error message
6) type 1 more character in the password field. Observe submit button

Actual: the submit button is disabled, even though the input has changed and is no longer invalid.
Expected: the submit button should be enabled as soon as input value changes.
Project Member

Comment 1 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c17889dd2837b9220bbc5f23c7f461e72691ced

commit 1c17889dd2837b9220bbc5f23c7f461e72691ced
Author: Scott Chen <scottchen@chromium.org>
Date: Thu May 31 22:25:51 2018

Settings: CrOS lock-screen password prompt logic fix.

The confirm button disabled state was being updated one cycle too late.

Bug:  847969 ,  846278 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib02b69f2cb22c4aa134b4f18f5962611790da654
Reviewed-on: https://chromium-review.googlesource.com/1079791
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563402}
[modify] https://crrev.com/1c17889dd2837b9220bbc5f23c7f461e72691ced/chrome/browser/resources/settings/people_page/password_prompt_dialog.html
[modify] https://crrev.com/1c17889dd2837b9220bbc5f23c7f461e72691ced/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[modify] https://crrev.com/1c17889dd2837b9220bbc5f23c7f461e72691ced/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js

Comment 2 by scottchen@chromium.org, Jun 1 2018

Status: Fixed (was: Started)
►

Sign in to add a comment