Views: Bookmarks Menu Hover Issue |
||||
Issue description1) Create a bookmark folder with a ton of items (to the point the bookmarks menu will have to be scrolled) 2) Open the bookmark folder's menu via the bookmarks bar 3) Hover one of the items 4) Scroll down Expected result: The item the mouse is now hovered on is highlighted Actual result: The old item is still highlighted. The item the mouse is on is not. This occurs on MacViews/Windows/Linux
,
Jun 12 2018
I'm taking this. I have a fix in Issue 847964 that should also fix this. Let me know if you want this back
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69beedd1cf95cbed38c32c2b8b8fa47569a5e2a4 commit 69beedd1cf95cbed38c32c2b8b8fa47569a5e2a4 Author: spqchan <spqchan@chromium.org> Date: Wed Jun 13 18:01:19 2018 [Views] Fix Menu Tooltip and Hover Issue There was an issue with the menu where if you scroll down it, the selected item and tooltip doesn't get updated. This CL address the issue by updating the selection on a mouse wheel event. On Mac, there is an issue where the incorrect tooltip is shown on the menu item. This issue happened because the tooltip manager doesn't get updated for mouse events on the Views menu. This CL fixes the issue by calling -updateTooltipIfRequiredAt: at -scrollWheel: and -processCapturedMouseEvent:. Bug: 847966 , 847964 Change-Id: I183de9a5a824ab5798957a3432da1962d65b75ca Reviewed-on: https://chromium-review.googlesource.com/1097739 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#566909} [modify] https://crrev.com/69beedd1cf95cbed38c32c2b8b8fa47569a5e2a4/ui/views/cocoa/bridged_content_view.mm [modify] https://crrev.com/69beedd1cf95cbed38c32c2b8b8fa47569a5e2a4/ui/views/controls/menu/menu_controller.cc
,
Jun 14 2018
,
Jun 15 2018
Able to reproduce the issue on chrome version 68.0.3440.0 Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 14.04 on Chrome version #69.0.3461.2 as per the comment#0 Attaching screen cast for reference. Observed "The item on which mouse is hovered is highlighted" Hence, the fix is working as expected. Adding the verified label. Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by ellyjo...@chromium.org
, Jun 5 2018Owner: lgrey@chromium.org
Status: Assigned (was: Untriaged)