New issue
Advanced search Search tips

Issue 847965 link

Starred by 1 user
Status: WontFix
Owner:
justincohen@chromium.org
Closed: May 2018
Cc:
edchin@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

FATAL:grid_view_controller.mm(421)] Check failed: cell.

Project Member Reported by justincohen@chromium.org, May 30 2018 
I see this pretty much every time I tap on a link from the NTP.

#3  0x0000000104f28580 in ::-[GridViewController configureCell:withItem:](GridCell *, GridItem *) at ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm:421
#4  0x0000000104f27360 in ::-[GridViewController replaceItemID:withItem:](NSString *, GridItem *) at ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm:364
#5  0x0000000104efde88 in ::-[TabGridMediator webState:didLoadPageWithSuccess:](web::WebState *, BOOL) at ios/chrome/browser/ui/tab_grid/tab_grid_mediator.mm:196
#6  0x00000001037e992c in web::WebStateObserverBridge::PageLoaded(web::WebState*, web::PageLoadCompletionStatus) at ios/web/web_state/web_state_observer_bridge.mm:95
#7  0x00000001037d406c in web::WebStateImpl::OnPageLoaded(GURL const&, bool) at ios/web/web_state/web_state_impl.mm:265
#8  0x0000000103821814 in ::-[CRWWebController didFinishWithURL:loadSuccess:context:](const GURL &, BOOL, const web::NavigationContext *) at ios/web/web_state/ui/crw_web_controller.mm:2108
#9  0x0000000103821198 in ::-[CRWWebController loadCompleteWithSuccess:forNavigation:](BOOL, WKNavigation *) at ios/web/web_state/ui/crw_web_controller.mm:2069
#10 0x0000000103820f5c in ::-[CRWWebController didFinishNavigation:](WKNavigation *) at ios/web/web_state/ui/crw_web_controller.mm:2050
#11 0x0000000103846b44 in ::-[CRWWebController webView:didFinishNavigation:](WKWebView *, WKNavigation *) at ios/web/web_state/ui/crw_web_controller.mm:4861

Comment 1 by justincohen@chromium.org, May 30 2018

Labels: -Pri-3 Pri-0
I can't even create a new tab:

'NSInternalInconsistencyException', reason: 'Invalid update: invalid number of items in section 0.  The number of items contained in an existing section after the update (2) must be equal to the number of items contained in that section before the update (0), plus or minus the number of items inserted or deleted from that section (1 inserted, 0 deleted) and plus or minus the number of items moved into or out of that section (0 moved in, 0 moved out).'

I'm on origin/master, so I don't think there's anything weird in my setup.  

This is blocking any work on iPad, marking it p0.

Comment 2 by justincohen@chromium.org, May 30 2018

Labels: MS-Tab-Grid Proj-UIRefresh
Status: Assigned (was: Untriaged)
--enable-features=UIRefreshPhase1

Comment 3 by justincohen@chromium.org, May 30 2018 

Seems like this requires a start with no tabs, or 1 tab.

Comment 4 by edchin@chromium.org, May 30 2018

Owner: edchin@chromium.org
Taking ownership. Trying to repro.

Comment 5 by edchin@chromium.org, May 30 2018

Status: Started (was: Assigned)

Comment 6 by edchin@chromium.org, May 30 2018 

Not able to repro on iPad Pro 9.7 inch simulator, iOS 11.3, ToT, with fresh install, 1 tab at start. Do you have any other repro steps that might help?

Comment 7 by justincohen@chromium.org, May 30 2018 

I'd be surprised, but I wonder if it's Xcode 9.4?

Comment 8 by edchin@chromium.org, May 30 2018 

I'm still downloading 9.4. Will let you know.

Comment 9 by justincohen@chromium.org, May 30 2018

Labels: -Pri-0 Pri-1
Removing p0 if it's not reproducible by everyone..

Comment 10 by edchin@chromium.org, May 30 2018

Owner: justincohen@chromium.org
Status: Assigned (was: Started)
Not a Xcode 9.4 issue. Still not able to repro. Passing back to justincohen@ for more repro steps.

Comment 11 by justincohen@chromium.org, May 31 2018

Status: WontFix (was: Assigned)
Sad, I was able to get myself out of this state by switching between refresh and non-refresh, and deleting all my tabs and recreating them.  I'll reopen if I can reproduce.
►

Sign in to add a comment