MacViews: Incorrect tooltip showed for bookmark menu |
|||
Issue descriptionSteps to reproduce: 1) Create a lot of bookmarks in a bookmark folder 2) Open the bookmark folder's menu in the bookmark bar 3) However on one of the items until the tooltip appears Expected result: The tooltip for the hovered bookmark item appears Actual results: The tooltip for the wrong item appears
,
Jun 11 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69beedd1cf95cbed38c32c2b8b8fa47569a5e2a4 commit 69beedd1cf95cbed38c32c2b8b8fa47569a5e2a4 Author: spqchan <spqchan@chromium.org> Date: Wed Jun 13 18:01:19 2018 [Views] Fix Menu Tooltip and Hover Issue There was an issue with the menu where if you scroll down it, the selected item and tooltip doesn't get updated. This CL address the issue by updating the selection on a mouse wheel event. On Mac, there is an issue where the incorrect tooltip is shown on the menu item. This issue happened because the tooltip manager doesn't get updated for mouse events on the Views menu. This CL fixes the issue by calling -updateTooltipIfRequiredAt: at -scrollWheel: and -processCapturedMouseEvent:. Bug: 847966 , 847964 Change-Id: I183de9a5a824ab5798957a3432da1962d65b75ca Reviewed-on: https://chromium-review.googlesource.com/1097739 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#566909} [modify] https://crrev.com/69beedd1cf95cbed38c32c2b8b8fa47569a5e2a4/ui/views/cocoa/bridged_content_view.mm [modify] https://crrev.com/69beedd1cf95cbed38c32c2b8b8fa47569a5e2a4/ui/views/controls/menu/menu_controller.cc
,
Jun 14 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ellyjo...@chromium.org
, May 31 2018Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)