[VR Browsing] Menu option 'New incognito tab' should not appear if already in incognito mode. |
||||||
Issue descriptionChrome Version: 68.0.3440.7 (also in M67) OS: N, O Device: Any daydream device What steps will reproduce the problem? (1) In VR browsing, open menu in Omnibox and select "New incognito tab". (2) Re-open the menu while in incognito mode. What is the expected result? Once in incognito mode, the option "New incognito tab" should not be available. What happens instead? The "New incognito tab" option is always available. Even in incognito mode. It should only appear in normal mode.
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e090f195ac208abb7756480ba8f1c808b10dd642 commit e090f195ac208abb7756480ba8f1c808b10dd642 Author: Christopher Grant <cjgrant@chromium.org> Date: Wed May 30 22:12:12 2018 VR: Do not show new-incognito-tab option if incognito BUG= 847950 R=mthiesse Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I4a6068bdea5b8b9836373876c6dde567e4714b00 Reviewed-on: https://chromium-review.googlesource.com/1079706 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#563013} [modify] https://crrev.com/e090f195ac208abb7756480ba8f1c808b10dd642/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/e090f195ac208abb7756480ba8f1c808b10dd642/chrome/browser/vr/ui_unittest.cc
,
May 31 2018
,
Jun 1 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45dcb3dc9090a2577f0cdd07f24af3e118668bdb commit 45dcb3dc9090a2577f0cdd07f24af3e118668bdb Author: Christopher Grant <cjgrant@chromium.org> Date: Fri Jun 01 21:29:08 2018 VR: Do not show new-incognito-tab option if incognito BUG= 847950 R=​mthiesse Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I4a6068bdea5b8b9836373876c6dde567e4714b00 Reviewed-on: https://chromium-review.googlesource.com/1079706 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563013}(cherry picked from commit e090f195ac208abb7756480ba8f1c808b10dd642) Reviewed-on: https://chromium-review.googlesource.com/1082942 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#100} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/45dcb3dc9090a2577f0cdd07f24af3e118668bdb/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/45dcb3dc9090a2577f0cdd07f24af3e118668bdb/chrome/browser/vr/ui_unittest.cc
,
Jun 1 2018
,
Jun 26 2018
Verified in Chrome Beta 68.0.3440.39
,
Jun 26 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by cjgrant@chromium.org
, May 30 2018