gtest output redirection is broken in test launcher |
||
Issue description1. Run net_unittest on Fuchsia 2. Observe that gtest output is dumped to the console, which doesn't happen on other platforms The problem is that stdio redirection logic is wrapped in OS_POSIX in base/test/launcher/test_launcher.cc . It doesn't works on Fuchsia because we no longer define OS_POSIX .
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ac7aa2041d11b4a4be4e7ba21e14836c8494248 commit 8ac7aa2041d11b4a4be4e7ba21e14836c8494248 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Fri Jun 01 18:10:18 2018 [Fuchsia] Fix stdout redirection in test launcher Test launcher was redirecting output only when OS_POSIX or OS_WIN are defined. We no longer define OS_POSIX on Fuchsia, so output redirection was broken. Updated ifdefs to redirect output on Fuchsia correclty. Bug: 847927 Change-Id: Id817280719f34a2470f1520b4e2039025fd7c8e2 Reviewed-on: https://chromium-review.googlesource.com/1079465 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#563721} [modify] https://crrev.com/8ac7aa2041d11b4a4be4e7ba21e14836c8494248/base/test/launcher/test_launcher.cc [modify] https://crrev.com/8ac7aa2041d11b4a4be4e7ba21e14836c8494248/base/test/launcher/test_launcher.h
,
Jun 1 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by w...@chromium.org
, May 30 2018