New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847922 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Sync server send unused tombstone updates to new client

Project Member Reported by li...@yandex-team.ru, May 30 2018

Issue description

Steps to reproduce the problem?
(1) Login to existing sync profile by new client.
(2) Look for number of tombstone updates on chrome://sync-internals 

USS and directory types do not use tombstone updates on first association.
So we send unused data from server to client.
Initial get update could be very massive and tombstone updates could reach 30%.
We can reduce time of initial association if filter tombstone updates on server.


 
Project Member

Comment 1 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0c9087ec8467716dd1126873273c1e65ecd736c

commit d0c9087ec8467716dd1126873273c1e65ecd736c
Author: Aleksei Loshkarev <lixan@yandex-team.ru>
Date: Thu May 31 14:51:13 2018

Fixes ConfigureReason for initial type configure

Now sync server could not distinguish initial get updates from
get updates on browser restart.
This cl fixes it by setting CONFIGURE_REASON_NEW_CLIENT
for initial get updates.

Bug:  847922 
Change-Id: Iaa9eb1ea2ec010baf3e9eb9c9ca2379a7502605b
Reviewed-on: https://chromium-review.googlesource.com/1079568
Commit-Queue: Aleksei Loshkarev <lixan@yandex-team.ru>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563227}
[modify] https://crrev.com/d0c9087ec8467716dd1126873273c1e65ecd736c/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/d0c9087ec8467716dd1126873273c1e65ecd736c/components/browser_sync/profile_sync_service_unittest.cc

Description: Show this description
Status: Assigned (was: Untriaged)
Status: Fixed (was: Assigned)

Sign in to add a comment