New issue
Advanced search Search tips

Issue 847918 link

Starred by 1 user
Status: Verified
Owner:
eyaich@chromium.org
Closed: Jun 2018
Cc:
eyaich@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

power.desktop needs to be scheduled on the waterfall

Project Member Reported by charliea@chromium.org, May 30 2018 
I'm in the process of consolidating two desktop power benchmarks, battor.trivial_sites and battor.steady_state, into a single desktop power benchmark: power.desktop.

This benchmark needs to be scheduled on the perf waterfall.

I'm going to start by launching perf try jobs for a few relevant platforms to make sure that it's looking stable on them.

Comment 4 by nednguyen@chromium.org, May 30 2018

Cc: eyaich@chromium.org

Comment 5 by charliea@chromium.org, May 30 2018 

I was holding off on CCing Emily/Ashley until I verify that the benchmark is passing on all platforms I'm enabling it on. Historically, this benchmark has only been enabled on Mac platforms but there's not a lot of good reason for that.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, May 30 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14b65f5a240000
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, May 30 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/12cf5d5a240000
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, May 30 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14f55a7a240000
Project Member

Comment 9 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bc6326b5f1f2b2151c5bf02b025206a69d07341

commit 0bc6326b5f1f2b2151c5bf02b025206a69d07341
Author: Charlie Andrews <charliea@chromium.org>
Date: Thu May 31 21:22:39 2018

Collapse battor.trivial_pages and battor.steady_state into power.desktop

I verified that this works on:

Linux: https://pinpoint-dot-chromeperf.appspot.com/job/12cf5d5a240000
Mac: https://pinpoint-dot-chromeperf.appspot.com/job/12cf5d5a240000
Windows: https://pinpoint-dot-chromeperf.appspot.com/job/14f55a7a240000

BUG= 737101 ,  847918 

Change-Id: I05fd698833db3695f9db4aba0d3549bc5d87c006
Reviewed-on: https://chromium-review.googlesource.com/1076953
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#563378}
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/benchmark.csv
[delete] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/tools/perf/benchmarks/battor.py
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/benchmarks/benchmark_smoke_unittest.py
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/benchmarks/power.py
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/core/benchmark_android_bot_map.json
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/core/benchmark_desktop_bot_map.json
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/core/benchmark_sharding_map.json
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/core/perf_data_generator.py
[rename] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/page_sets/data/desktop_power_stories.json
[add] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/page_sets/desktop_power.py
[delete] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/tools/perf/page_sets/idle_after_loading_stories.py

Comment 10 by charliea@chromium.org, Jun 1 2018

Owner: eyaich@chromium.org
Emily, could you please schedule this benchmark on the desktop waterfall?

Comment 12 by charliea@chromium.org, Jun 4 2018

Status: Verified (was: Assigned)
This is now running on the waterfall: https://chromeperf.appspot.com/report?sid=716a1c2e8af375d428335b92f453b5e9c7ed4986a16ed4e1855d9711ff82ee55

Thanks Emily!
►

Sign in to add a comment