New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 847897 link

Starred by 1 user
Status: Fixed
Owner:
liaoyuke@chromium.org
Closed: Jun 2018
Cc:
jbudorick@chromium.org
█ robert...@chromium.org
liaoyuke@chromium.org
mmoroz@chromium.org
infe...@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 825362



Sign in to add a comment

Use post_process to test coverage recipes

Project Member Reported by liaoyuke@chromium.org, May 30 2018 
A comment in https://chromium-review.googlesource.com/c/chromium/tools/build/+/1079206/1/scripts/slave/recipes/chromium_clang_coverage_reports.py mentioned that "Generating a test for every builder is liable to result in unusable noise. I've been trying to advocate for using post_process (https://codesearch.chromium.org/chromium/infra/recipes-py/recipe_engine/post_process.py) in new code to explicitly assert on what you care about & then drop the expectations."
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/e51ca155a3de3097f6869d1b21bf718440a00d0d

commit e51ca155a3de3097f6869d1b21bf718440a00d0d
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Jun 12 22:10:52 2018

Coverage: Use post_process to test the recipe and drop the expectation

This CL changes the chromium_clang_coverage_reports recipe to use
post_process for testing and drop the expectation.

Bug:  847897 ,  825362 
Change-Id: I1abec36c8a6e8be2ed4c26187516572224a0f246
Reviewed-on: https://chromium-review.googlesource.com/1095115
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/e51ca155a3de3097f6869d1b21bf718440a00d0d/scripts/slave/README.recipes.md
[modify] https://crrev.com/e51ca155a3de3097f6869d1b21bf718440a00d0d/scripts/slave/recipes/chromium_clang_coverage_reports.py
[delete] https://crrev.com/98b92d03f5edb31cfbab045189970e8fafacc323/scripts/slave/recipes/chromium_clang_coverage_reports.expected/full_chromium_fyi_linux_code_coverage_generation.json

Comment 2 by liaoyuke@chromium.org, Jun 12 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment