Spacey flagging mandatory trailing spaces in PDF XREF tables |
|||||
Issue descriptionSee, say, https://tricium-prod.appspot.com/run/5080917185921024 The PDF file format requires that these XREF table entries be exactly 20 bytes long, with a trailing space when there is a LF ending (as opposed to CRLF). This is generating a bunch of spurious warnings at present.
,
May 30 2018
,
May 30 2018
,
May 30 2018
Ah, sorry for the noise :-) The quick fix here is to edit the "trailing spaces" check file type blacklist. CL: https://chromium-review.googlesource.com/#/c/infra/infra/+/1079730
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/295307b93f4713919ddd11d4c40617fe45a066e1 commit 295307b93f4713919ddd11d4c40617fe45a066e1 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Fri Jun 01 00:44:13 2018 [tricium spacey] Don't check for trailing spaces in .pdf files Bug: 847892 Change-Id: I5f9f7d20ce11daaaafe20f6197498218312dc189 Reviewed-on: https://chromium-review.googlesource.com/1079730 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/295307b93f4713919ddd11d4c40617fe45a066e1/go/src/infra/tricium/functions/spacey/spacey.go [modify] https://crrev.com/295307b93f4713919ddd11d4c40617fe45a066e1/go/src/infra/tricium/functions/spacey/spacey_test.go
,
Jun 1 2018
New version of Spacey deployed; this should be fixed now. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tsepez@chromium.org
, May 30 2018