Cpu profiler misplaces callstack frames. |
||||
Issue descriptionCpu profiler misplaces callstack frames. See the attached profile.
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7ca97d0c3786d65e81f25788ffcadbc302a8756 commit c7ca97d0c3786d65e81f25788ffcadbc302a8756 Author: Alexei Filippov <alph@chromium.org> Date: Wed May 30 21:38:38 2018 DevTools: Fix CPU profile frames being offset by 1 sample. In CPU profile samples delta for the first sample is an offset from startTime. BUG= 847887 Change-Id: I200eae40770b521545c831f0e6e1ffa311cb7a85 Reviewed-on: https://chromium-review.googlesource.com/1079432 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#563006} [modify] https://crrev.com/c7ca97d0c3786d65e81f25788ffcadbc302a8756/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-fix-missing-samples-expected.txt [modify] https://crrev.com/c7ca97d0c3786d65e81f25788ffcadbc302a8756/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-parsing-expected.txt [modify] https://crrev.com/c7ca97d0c3786d65e81f25788ffcadbc302a8756/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-streamed-cpu-profile-expected.txt [modify] https://crrev.com/c7ca97d0c3786d65e81f25788ffcadbc302a8756/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/trace-event-self-time-expected.txt [modify] https://crrev.com/c7ca97d0c3786d65e81f25788ffcadbc302a8756/third_party/blink/renderer/devtools/front_end/sdk/CPUProfileDataModel.js
,
May 30 2018
,
May 31 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 4 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 8 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e9c12733a9ac7077cdf60676e7c3035411021b3 commit 0e9c12733a9ac7077cdf60676e7c3035411021b3 Author: Alexei Filippov <alph@chromium.org> Date: Fri Jun 08 18:14:15 2018 DevTools: Fix CPU profile frames being offset by 1 sample. In CPU profile samples delta for the first sample is an offset from startTime. BUG= 847887 TBR=alph@chromium.org (cherry picked from commit c7ca97d0c3786d65e81f25788ffcadbc302a8756) Change-Id: I200eae40770b521545c831f0e6e1ffa311cb7a85 Reviewed-on: https://chromium-review.googlesource.com/1079432 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563006} Reviewed-on: https://chromium-review.googlesource.com/1093427 Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#262} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/0e9c12733a9ac7077cdf60676e7c3035411021b3/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-fix-missing-samples-expected.txt [modify] https://crrev.com/0e9c12733a9ac7077cdf60676e7c3035411021b3/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-parsing-expected.txt [modify] https://crrev.com/0e9c12733a9ac7077cdf60676e7c3035411021b3/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-streamed-cpu-profile-expected.txt [modify] https://crrev.com/0e9c12733a9ac7077cdf60676e7c3035411021b3/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/trace-event-self-time-expected.txt [modify] https://crrev.com/0e9c12733a9ac7077cdf60676e7c3035411021b3/third_party/blink/renderer/devtools/front_end/sdk/CPUProfileDataModel.js |
||||
►
Sign in to add a comment |
||||
Comment 1 by alph@chromium.org
, May 30 20181.2 MB
1.2 MB Download