New issue
Advanced search Search tips

Issue 847876 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove memory peak detection code.

Project Member Reported by erikc...@chromium.org, May 30 2018

Issue description

The code is currently unused. This CL: https://chromium-review.googlesource.com/c/chromium/src/+/1076506 removes it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5

commit 6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5
Author: erikchen <erikchen@chromium.org>
Date: Wed May 30 15:36:36 2018

Remove memory peak detection code.

This CL removes dead code. It has no intended behavior change.

Change-Id: I5f5cabb2e162da82777a168df191c14fd0f9a295
Bug:  847876 
TBR: dpranke@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1076506
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562836}
[modify] https://crrev.com/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5/base/BUILD.gn
[modify] https://crrev.com/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5/base/trace_event/memory_dump_manager.h
[modify] https://crrev.com/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5/base/trace_event/memory_dump_provider.h
[modify] https://crrev.com/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5/base/trace_event/memory_dump_request_args.cc
[modify] https://crrev.com/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5/base/trace_event/memory_dump_request_args.h
[delete] https://crrev.com/422b4901e0a2a4a5c6e51af7f59f70c43fd609b8/base/trace_event/memory_peak_detector.cc
[delete] https://crrev.com/422b4901e0a2a4a5c6e51af7f59f70c43fd609b8/base/trace_event/memory_peak_detector.h
[delete] https://crrev.com/422b4901e0a2a4a5c6e51af7f59f70c43fd609b8/base/trace_event/memory_peak_detector_unittest.cc
[modify] https://crrev.com/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5/base/trace_event/trace_config_memory_test_util.h
[modify] https://crrev.com/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5/base/trace_event/trace_config_unittest.cc
[modify] https://crrev.com/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
[modify] https://crrev.com/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.h
[modify] https://crrev.com/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation_mojom_traits.cc
[modify] https://crrev.com/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_integration_unittest.cc
[modify] https://crrev.com/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5/services/resource_coordinator/public/mojom/memory_instrumentation/memory_instrumentation.mojom
[modify] https://crrev.com/6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5/tools/gn/bootstrap/bootstrap.py

Sign in to add a comment