New issue
Advanced search Search tips

Issue 847872 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

Enforce schema validation for JSON policies

Project Member Reported by olsen@chromium.org, May 30 2018

Issue description

See 
https://bugs.chromium.org/p/chromium/issues/detail?id=834804 - as tracked in that bug we implemented error reporting for JSON policies with unparsable JSON, or JSON that didn't match the schema. However, we still don't reject policies that we consider invalid - not until we are sure that the validator is working properly and we won't break anything.

This bug is to track that change - once we are sure the validators are working properly, and that nobody is relying on the ability to store invalid JSON policies in the pref store, we should reject invalid policies. This can be done simply by setting allow_errors_in_embedded_json_ to false.
 

Comment 1 by olsen@chromium.org, Jun 27 2018

Status: WontFix (was: Assigned)
Will not fix - "enforcing" policies - that is, dropping invalid values during validation - has no real benefit. A partially valid value might still be useful if kept, and a completely invalid value has no effect (because the code that reads these policies was already written defensively since there was no validation)

Sign in to add a comment