New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847857 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 760553
issue 849392
issue 872551



Sign in to add a comment

Rename smoothness page sets

Project Member Reported by amyqiu@google.com, May 30 2018

Issue description

To ensure consistency once smoothness benchmarks are merged into rendering.mobile and rendering.desktop, page sets need to be renamed according to the "page_name" pattern.

 
Cc: sadrul@chromium.org
Once you finished with all the renaming, can you compose a list of of page names which have changed so that perf dashboard service team can help do the name migration?

Comment 2 by amyqiu@google.com, May 30 2018

Yup, here is a spreadsheet of the renames in-progress. 

https://docs.google.com/spreadsheets/d/1imuAw-JA1vOu3jG9qEjeyP6DU5eRylQH7ct7QB1L0OA/edit?usp=sharing
Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b223cec9a9497308c737e54e964c21c255d3d0df

commit b223cec9a9497308c737e54e964c21c255d3d0df
Author: Amy Qiu <amyqiu@google.com>
Date: Wed May 30 16:27:39 2018

Rename tough_canvas_cases pages for consistency

Refactor name of pages to be more consistent with those in the
rendering._ page sets.

Bug:  847857 
Change-Id: Iae8935894b171b3637a90cbcc4c8730e43e7bb06
Reviewed-on: https://chromium-review.googlesource.com/1079040
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#562860}
[modify] https://crrev.com/b223cec9a9497308c737e54e964c21c255d3d0df/tools/perf/expectations.config
[modify] https://crrev.com/b223cec9a9497308c737e54e964c21c255d3d0df/tools/perf/page_sets/data/tough_canvas_cases.json
[modify] https://crrev.com/b223cec9a9497308c737e54e964c21c255d3d0df/tools/perf/page_sets/tough_canvas_cases.py

Project Member

Comment 4 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/726d245ded6d501a4d5bb625884b3e48d8a16165

commit 726d245ded6d501a4d5bb625884b3e48d8a16165
Author: Amy Qiu <amyqiu@google.com>
Date: Wed May 30 18:35:49 2018

Rename tough_webgl_cases page sets for consistency

Rename so that pages follow the same naming convention as rendering page
sets.

Bug:  847857 
Change-Id: If96e8e1548ae3c0f3bc769e11eb0be1a10cfdf89
Reviewed-on: https://chromium-review.googlesource.com/1079194
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#562926}
[modify] https://crrev.com/726d245ded6d501a4d5bb625884b3e48d8a16165/tools/perf/page_sets/data/tough_webgl_cases.json
[modify] https://crrev.com/726d245ded6d501a4d5bb625884b3e48d8a16165/tools/perf/page_sets/tough_webgl_cases.py

Project Member

Comment 5 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaef559728300db4056954dfb452dd3c510c6bd2

commit aaef559728300db4056954dfb452dd3c510c6bd2
Author: Amy Qiu <amyqiu@google.com>
Date: Thu May 31 13:29:54 2018

Rename tough_animation_cases pages for consistency

Rename so that pages have same naming convention as rendering page sets.

Bug:  847857 
Change-Id: I46da09f0e7528525cb8d9f545db3b081d15478e6
Reviewed-on: https://chromium-review.googlesource.com/1079814
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#563208}
[modify] https://crrev.com/aaef559728300db4056954dfb452dd3c510c6bd2/tools/perf/expectations.config
[modify] https://crrev.com/aaef559728300db4056954dfb452dd3c510c6bd2/tools/perf/page_sets/data/tough_animation_cases.json
[modify] https://crrev.com/aaef559728300db4056954dfb452dd3c510c6bd2/tools/perf/page_sets/tough_animation_cases.py

Project Member

Comment 6 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a76735c37fba27f674348e99922b76c2c7a74f7d

commit a76735c37fba27f674348e99922b76c2c7a74f7d
Author: Amy Qiu <amyqiu@google.com>
Date: Thu May 31 23:38:31 2018

Rename pages in tough_pinch_zoom_cases

Rename pages to be consistent with naming convention in rendering page
sets

Bug:  847857 
Change-Id: Id7a1e265b80db1830500ab8c306dfc40fecc9046
Reviewed-on: https://chromium-review.googlesource.com/1081195
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#563432}
[modify] https://crrev.com/a76735c37fba27f674348e99922b76c2c7a74f7d/tools/perf/expectations.config
[modify] https://crrev.com/a76735c37fba27f674348e99922b76c2c7a74f7d/tools/perf/page_sets/data/tough_pinch_zoom_cases.json
[modify] https://crrev.com/a76735c37fba27f674348e99922b76c2c7a74f7d/tools/perf/page_sets/tough_pinch_zoom_cases.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4154198e5ff1a9ee1463f2053eab0641958207e0

commit 4154198e5ff1a9ee1463f2053eab0641958207e0
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Jun 01 00:27:15 2018

Update names of a couple of tough_webgl_cases pages.

Bug:  847857 
Change-Id: Iaae0daf68ccdf5a02d193a1b62b11689c83764b7
Reviewed-on: https://chromium-review.googlesource.com/1081344
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563457}
[modify] https://crrev.com/4154198e5ff1a9ee1463f2053eab0641958207e0/tools/perf/page_sets/data/tough_webgl_cases.json
[modify] https://crrev.com/4154198e5ff1a9ee1463f2053eab0641958207e0/tools/perf/page_sets/tough_webgl_cases.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e57ca477ad8697b47d6d495f2ed0d7ade499202b

commit e57ca477ad8697b47d6d495f2ed0d7ade499202b
Author: Amy Qiu <amyqiu@google.com>
Date: Fri Jun 01 14:24:05 2018

Rename simple_mobile_sites pages for consistency

Rename so that pages follow the same naming convention as those in the
rendering page sets

Bug:  847857 
Change-Id: I2fcd7ddd3b0b67c00d457f1a47ed19c4686ce9e5
Reviewed-on: https://chromium-review.googlesource.com/1081017
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#563616}
[modify] https://crrev.com/e57ca477ad8697b47d6d495f2ed0d7ade499202b/tools/perf/expectations.config
[modify] https://crrev.com/e57ca477ad8697b47d6d495f2ed0d7ade499202b/tools/perf/page_sets/data/simple_mobile_sites.json
[modify] https://crrev.com/e57ca477ad8697b47d6d495f2ed0d7ade499202b/tools/perf/page_sets/simple_mobile_sites.py

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a0ae95d63c0ff36e43251637ccee8ab323e73ec

commit 8a0ae95d63c0ff36e43251637ccee8ab323e73ec
Author: Amy Qiu <amyqiu@google.com>
Date: Fri Jun 01 19:34:51 2018

Delete unused pages from key_silk_cases.json

Some of the pages in this page set are no longer used, therefore remove
them for better maintainability.

Bug:  847857 
Change-Id: I0986dfd3a96275d467940caad1d8345654f9e3d5
Reviewed-on: https://chromium-review.googlesource.com/1082243
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#563754}
[modify] https://crrev.com/8a0ae95d63c0ff36e43251637ccee8ab323e73ec/tools/perf/page_sets/data/key_silk_cases.json

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a74b47ec199c9e7a05ca34386e51af3f42608a7b

commit a74b47ec199c9e7a05ca34386e51af3f42608a7b
Author: Amy Qiu <amyqiu@google.com>
Date: Fri Jun 01 21:23:50 2018

Rename pages in pathological_mobile_sites

Rename pages to be consistent with naming convention in rendering page
sets

Bug:  847857 
Change-Id: I45aebbd5a4f3cae9be7a6858c483f3ef4cec3df2
Reviewed-on: https://chromium-review.googlesource.com/1082989
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#563801}
[modify] https://crrev.com/a74b47ec199c9e7a05ca34386e51af3f42608a7b/tools/perf/expectations.config
[modify] https://crrev.com/a74b47ec199c9e7a05ca34386e51af3f42608a7b/tools/perf/page_sets/data/pathological_mobile_sites.json
[modify] https://crrev.com/a74b47ec199c9e7a05ca34386e51af3f42608a7b/tools/perf/page_sets/pathological_mobile_sites.py

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be71236d2c257e74fb599c1ec96fd7e8b116e2c9

commit be71236d2c257e74fb599c1ec96fd7e8b116e2c9
Author: Amy Qiu <amyqiu@google.com>
Date: Mon Jun 04 17:55:14 2018

Rename pages in tough_scheduling_cases

Rename pages to be consistent with naming convention in Rendering page
sets

Bug:  847857 
Change-Id: Id126b0f4738ffb1910124e2bdae6fba197f2d3af
Reviewed-on: https://chromium-review.googlesource.com/1082967
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#564148}
[modify] https://crrev.com/be71236d2c257e74fb599c1ec96fd7e8b116e2c9/tools/perf/page_sets/tough_scheduling_cases.py

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6152ceb09e2b37d0b51bd8c1366dd027eb8acae7

commit 6152ceb09e2b37d0b51bd8c1366dd027eb8acae7
Author: Amy Qiu <amyqiu@google.com>
Date: Mon Jun 04 18:56:22 2018

Rename page in image_decoding_cases

Rename page to be more consistent with pages in the rendering page sets

Bug:  847857 
Change-Id: I2753de3afecc2da07bd3ee77daa658b56175993f
Reviewed-on: https://chromium-review.googlesource.com/1082964
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#564172}
[modify] https://crrev.com/6152ceb09e2b37d0b51bd8c1366dd027eb8acae7/tools/perf/page_sets/image_decoding_cases.py

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f5f59ed620845ce3846074079e832eea32bffb5

commit 8f5f59ed620845ce3846074079e832eea32bffb5
Author: Amy Qiu <amyqiu@google.com>
Date: Mon Jun 04 19:12:58 2018

Rename pages in key_silk_cases

Rename pages to be consistent with naming convention in Rendering page
sets

Bug:  847857 
Change-Id: If1cdf895924a05211c21fc973e8054f659cbd260
Reviewed-on: https://chromium-review.googlesource.com/1080463
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#564177}
[modify] https://crrev.com/8f5f59ed620845ce3846074079e832eea32bffb5/tools/perf/expectations.config
[modify] https://crrev.com/8f5f59ed620845ce3846074079e832eea32bffb5/tools/perf/page_sets/data/key_silk_cases.json
[modify] https://crrev.com/8f5f59ed620845ce3846074079e832eea32bffb5/tools/perf/page_sets/key_silk_cases.py

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/780320ac93db0d49e0b1ff0bb5c7d05c038889f6

commit 780320ac93db0d49e0b1ff0bb5c7d05c038889f6
Author: Amy Qiu <amyqiu@google.com>
Date: Mon Jun 04 20:14:02 2018

Rename pages in tough_texture_upload_cases

Rename pages to be consistent with naming convention in rendering page
sets

Bug:  847857 
Change-Id: I50030a7edede3dc914482f8d9ff114c1f8702350
Reviewed-on: https://chromium-review.googlesource.com/1083014
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#564209}
[modify] https://crrev.com/780320ac93db0d49e0b1ff0bb5c7d05c038889f6/tools/perf/expectations.config
[modify] https://crrev.com/780320ac93db0d49e0b1ff0bb5c7d05c038889f6/tools/perf/page_sets/tough_texture_upload_cases.py

Comment 15 by amyqiu@google.com, Jun 4 2018

Blocking: 849392
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f71c6a92aa8a35f7edd01d464cf0f7d38c0e9aac

commit f71c6a92aa8a35f7edd01d464cf0f7d38c0e9aac
Author: Amy Qiu <amyqiu@google.com>
Date: Tue Jun 05 14:43:05 2018

Rename pages in tough_image_decode_cases

Rename pages to be consistent with naming convention in rendering page
sets

Bug:  847857 
Change-Id: Id685fe31146e105949ade11844bb492bf13333a9
Reviewed-on: https://chromium-review.googlesource.com/1082963
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#564491}
[modify] https://crrev.com/f71c6a92aa8a35f7edd01d464cf0f7d38c0e9aac/tools/perf/page_sets/data/tough_image_decode_cases.json
[modify] https://crrev.com/f71c6a92aa8a35f7edd01d464cf0f7d38c0e9aac/tools/perf/page_sets/tough_image_decode_cases.py

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5769ff8579fb0659b1b24573a2867364cd052e13

commit 5769ff8579fb0659b1b24573a2867364cd052e13
Author: Amy Qiu <amyqiu@google.com>
Date: Tue Jun 05 17:04:08 2018

Rename pages in polymer.py

Rename pages to be consistent with naming convention in Rendering page
sets.

Bug:  847857 
Change-Id: If4ab6d1d5abdff003c25710abc08d501cc6e1eaf
Reviewed-on: https://chromium-review.googlesource.com/1081025
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#564547}
[modify] https://crrev.com/5769ff8579fb0659b1b24573a2867364cd052e13/tools/perf/page_sets/data/polymer.json
[modify] https://crrev.com/5769ff8579fb0659b1b24573a2867364cd052e13/tools/perf/page_sets/polymer.py

Cc: amyqiu@google.com
Components: Speed>Dashboard
Labels: -Pri-3 Pri-1
Owner: simonhatch@chromium.org
Looks like all the pages are rename? 

Simon: can you help with triaging the perf dashboard renaming? The renames pages are in https://docs.google.com/spreadsheets/d/1imuAw-JA1vOu3jG9qEjeyP6DU5eRylQH7ct7QB1L0OA/edit#gid=0
Cc: -nedngu...@google.com nednguyen@chromium.org
Owner: amyqiu@google.com
Status: Fixed (was: Started)
Actually we seem to have a separate bug for the perf dashboar renaming:  issue 849745 
Project Member

Comment 21 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce61a003bfcb53430b7d972aa65fbed278dfcc37

commit ce61a003bfcb53430b7d972aa65fbed278dfcc37
Author: Amy Qiu <amyqiu@google.com>
Date: Wed Jun 27 23:54:35 2018

Rename key hit test cases

Rename page names in key hit test cases to be consistent with rendering
page sets

Bug:  847857 
Change-Id: I8f67d1efe34218c01e1d7e3e4a57c6d08e0553d5
Reviewed-on: https://chromium-review.googlesource.com/1117441
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#570944}
[modify] https://crrev.com/ce61a003bfcb53430b7d972aa65fbed278dfcc37/tools/perf/page_sets/key_hit_test_cases.py

Project Member

Comment 22 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fae396696dbdfa5e8f7cb4843f4da7bdc6d0210

commit 4fae396696dbdfa5e8f7cb4843f4da7bdc6d0210
Author: Amy Qiu <amyqiu@google.com>
Date: Wed Jun 27 23:54:54 2018

Rename pages in tough_compositor_cases

Rename pages in tough_compositor_cases to be consistent with rendering
page sets. In tough_compositor_cases.json, remove unused pages.

Bug:  847857 
Change-Id: Iaa697acd52da6389f6367f02910bf92759af606f
Reviewed-on: https://chromium-review.googlesource.com/1117467
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#570945}
[modify] https://crrev.com/4fae396696dbdfa5e8f7cb4843f4da7bdc6d0210/tools/perf/page_sets/data/tough_compositor_cases.json
[modify] https://crrev.com/4fae396696dbdfa5e8f7cb4843f4da7bdc6d0210/tools/perf/page_sets/tough_compositor_cases.py

Project Member

Comment 23 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e767ee3e1dc020a29fbd8cfe9a8530791b683961

commit e767ee3e1dc020a29fbd8cfe9a8530791b683961
Author: Amy Qiu <amyqiu@google.com>
Date: Thu Jun 28 00:18:54 2018

Rename pages in key_noop_cases

Rename pages in key_noop_cases.py to be consistent with rendering page
sets

Bug:  847857 
Change-Id: I432509b893a0943fd59ee40813fac520eaa59f9a
Reviewed-on: https://chromium-review.googlesource.com/1117444
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#570966}
[modify] https://crrev.com/e767ee3e1dc020a29fbd8cfe9a8530791b683961/tools/perf/page_sets/key_noop_cases.py

Blocking: 872551

Sign in to add a comment