third_party/fuchsia-sdk causes tools/licenses.py to fail |
||||||
Issue descriptionlicenses.py throws a LicenseError that looks like this when scanning third_party/fuchsia-sdk: licenses.LicenseError: Errors in third_party/fuchsia-sdk: License file not found. Either add a file named LICENSE, import upstream's COPYING if available, or add a 'License File:' line to README.chromium with the appropriate path.
,
Aug 8
Thanks for reporting this issue; kmarshall@ has just started looking at this.
,
Oct 12
Fixed in https://chromium-review.googlesource.com/1155831 (commit 8f688b5f1d752df95e29608afc215c1363aa8344)
,
Oct 12
,
Oct 15
It still fails here on master (I'm at commit d0852575f8d42bcf45ad26d0c46bda23b025693d): /data/src/chromium/src % ./tools/licenses.py scan [...] third_party/fuchsia-sdk: Errors in third_party/fuchsia-sdk: License file not found. Either add a file named LICENSE, import upstream's COPYING if available, or add a 'License File:' line to README.chromium with the appropriate path. [...] I don't see anything changing third_party/fuchsia-sdk in the commit mentioned in comment #3.
,
Oct 15
I guess this might be happening when 'fuchsia' isn't in .gclient target_os so we don't run the Fuchsia-specific hooks?
,
Oct 15
Re #6: We definitely don't have a LICENSE file in there, but neither do we have "License File:" in README.chromium, so where is it picking things up from when target_os="fuchsia" _is_ defined?
,
Oct 15
Oh, I didn't look very carefully, I just saw something about "generate LICENSE" in kmarshall's cl, so I assumed that was covering it.
,
Oct 15
Re #8: The CL at #3 creates the overall LICENSE file for the webrunner - the error in #5 is the tool complaining that the SDK license file is missing, I think?
,
Jan 15
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by raphael....@intel.com
, Aug 8