Issue metadata
Sign in to add a comment
|
Omnibox slightly moves upwards and truncates to the status bar. |
||||||||||||||||||||||
Issue descriptionApp Version: 68.0.3440.9 beta iOS Version: 10.3.3 only Device: iPhones Steps to reproduce: 1. Launch chrome. 2. Goto youtube.com 3. Tap on any video. 4. Play the video in full screen. 5. Change the device orientation to landscape mode. 6. Come out of full screen. Observed results: Omnibox slightly moves upwards and truncates the status bar. Expected results: Omnibox should not truncate the status bar. Number of times you were able to reproduce: 3/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No in M67 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes in M68 Link to video/image: Image : https://drive.google.com/file/d/1pQpZEOAIpQ4ywIUjJPX1w06HJyq6qmXu/view?usp=sharing Video : https://drive.google.com/file/d/1GRFsY4dAlxqSC2bQEM3X4vfM573omLvn/view?usp=sharing
,
May 30 2018
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecc0d4f56d87608c15fccb04899dd0df940041bc commit ecc0d4f56d87608c15fccb04899dd0df940041bc Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Thu May 31 18:15:13 2018 [iOS] Use notifications to update toolbar height for background rotation When the device is rotated while the window is not key, we do not receive any notification for when the top layout guide's length is updated. Bug: 847814 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I54c7e25d7222f0da00295b4efb89f414df1aee18 Reviewed-on: https://chromium-review.googlesource.com/1080067 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#563319} [modify] https://crrev.com/ecc0d4f56d87608c15fccb04899dd0df940041bc/ios/chrome/browser/ui/browser_view_controller.mm
,
Jun 1 2018
,
Jun 2 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/166c2886c3f041d5862822021371b984acd71679 commit 166c2886c3f041d5862822021371b984acd71679 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Sat Jun 02 02:07:33 2018 [iOS] Use notifications to update toolbar height for background rotation When the device is rotated while the window is not key, we do not receive any notification for when the top layout guide's length is updated. Bug: 847814 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I54c7e25d7222f0da00295b4efb89f414df1aee18 Reviewed-on: https://chromium-review.googlesource.com/1080067 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563319}(cherry picked from commit ecc0d4f56d87608c15fccb04899dd0df940041bc) Reviewed-on: https://chromium-review.googlesource.com/1084012 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#115} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/166c2886c3f041d5862822021371b984acd71679/ios/chrome/browser/ui/browser_view_controller.mm
,
Jun 5 2018
Verified on chrome canary version 69.0.3450.0 on iPhone 6 plus with iOS 10.3.3, following steps mentioned in comment #0. Omnibox does not cover the status bar. Looks good.
,
Jun 5 2018
,
Jun 6 2018
Verified the issue on the build version 68.0.3440.14 beta tested on iPhone6 iOS 10. Omnibox doesnt truncates with the status bar, works fine |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by justincohen@chromium.org
, May 30 2018Owner: kkhorimoto@chromium.org
Status: Assigned (was: Untriaged)