Regression: Unwanted blank space is seen in "Service Workers" window of DevTools
Reported by
khushal....@etouch.net,
May 30 2018
|
|||
Issue descriptionChrome Version : 68.0.3440.7 (Official Build)Revision 9bbd2d0687bd83181f22ac13565501690ee5b4c7-refs/branch-heads/3440@{#16} (32/64-bit) OS: Win (7, 8, 8.1, 10), Mac (10.12.6, 10.13.1, 10.13.5) & Linux (14.04 LTS). Steps to reproduce: 1. Launch chrome, navigate to NTP, open DevTools window and Run Audit. 2. Visit "Application" section and select "Service Workers" from the list. 3. Now move the horizontal scroll bar towards extreme right and Observe. Actual Result: Unwanted blank space is seen in "Service Workers" window of DevTools. Expected Result: Unwanted blank space should not be seen in "Service Workers" window of DevTools. This is Regression issue broken in 'M-64’ and providing the bisect info below: Good Build: 64.0.3279.0 (Revision: 519519) Bad Build: 64.0.3280.0 (Revision: 519958) Narrow bisect URL: https://chromium.googlesource.com/chromium/src/+log/ff113a8b5de28317d7f4820d0f6bd43e6e0ee033..cc5c369bf8072b35bad5b148d74f01b5afa4ba29?pretty=fuller&n=100 Suspecting: r519852 ? @eostroukhov: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Issue is also seen on M-67 Stable & Beta (build #67.0.3396.62) & M-69 Canary (build #69.0.3445.0). Kindly refer attached screen-cast. Thank You..!!
,
Oct 31
This issue is related to weird behaviors when auditing the NTP (new tab page). Auditing non-[http|https|chrome-extension] sites is disabled since M62 by inspecting the tab's URL (implemented by CL 639032). However, NTP's URL does not satisfy the condition of disabling because NTP's URL starts with "https" until M72. Since M72, NTP URL satisfies the condition, so auditing the NTP is disabled. This bug does not appear on other audit-able sites, hence obsoleting this issue.
,
Oct 31
This issue reveals itself when the script name is too long 1. visit plus.google.com 2. launch devtools > Application 3. refresh the tab 4. Check the name of the script of the site's service worker Observed behavior: the text overflows out of the right boundary.
,
Nov 1
Addressed by CL 1312973. Long strings in the script name and/or client name field are clipped and suffixed with ellipsis. The script name is still copyable and clickable, and hovering above it gives the whole string.
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/244ff23665600a61c9c2ef5ce16951ea7e7100e2 commit 244ff23665600a61c9c2ef5ce16951ea7e7100e2 Author: Harley Li <hhli@chromium.org> Date: Thu Nov 01 23:58:09 2018 [DevTools] Handle long string in service worker list's script name and clients If the name string of the service worker script or a service worker client is too long, this patch restricts its width and denote the overflow with ellipsis. Users can still get the string by hovering above it, and the string is still clickable. Bug: 847801 Change-Id: I9d3a07c410af6bb98ae42046894ea3d7223afcbc Reviewed-on: https://chromium-review.googlesource.com/c/1312973 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#604760} [modify] https://crrev.com/244ff23665600a61c9c2ef5ce16951ea7e7100e2/third_party/blink/renderer/devtools/front_end/resources/ServiceWorkersView.js [modify] https://crrev.com/244ff23665600a61c9c2ef5ce16951ea7e7100e2/third_party/blink/renderer/devtools/front_end/resources/serviceWorkersView.css
,
Nov 2
Update: Rechecked the above issue on Win (7, 8, 8.1, 10), Mac (10.13.1, 10.13.6, 10.14.1) and Linux (14.04 LTS) using latest Canary version 72.0.3599.0 and the issue is found Fixed. Hence, adding TE verified labels. Please refer the attached screen-cast. Thank You..!! |
|||
►
Sign in to add a comment |
|||
Comment 1 by dgozman@chromium.org
, Oct 12