New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847800 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression :Swiping is not smooth and consistent to navigate to next page in the Apps folder of App Launcher

Project Member Reported by mmanchala@chromium.org, May 30 2018

Issue description

Chrome Version: 66.0.3359.203/10452.99.0 Stable-channel Daisy,Kip and Reks 
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Open App Launcher 
(2)Now drag any App into another App so that Folder is created -> drag 20-22 apps so that next page in Folder will be created 
(3)Now try to swipe right and left using touch pad to navigate to next page in the folder-> observe unable to swipe every time(Inconsistent Behavior is seen) and its not smooth
(Please refer Video)

Expected: Should be able to swipe right and left consistently and also navigation should be smooth 
Actual: Instead Inconsistent behavior is seen while swiping to navigate to next page in the folder

This is Non-Regression Issue seen from M-65

@weidongg: Please confirm the Issue

Note : In M-64 unable to add more than 20 apps, so no other page is seen
 
Actual_UnableToSwipe.mp4
7.6 MB View Download
Expected_Scrolling.webm
2.4 MB View Download
Summary: Non-Regression :Swiping is not smooth and consistent to navigate to next page in the Apps folder of App Launcher (was: Non-Regression : Swiping is not smooth and consistent to navigate to next page in the Apps folder of App Launcher)
Labels: app-list-folder
After I swiped to 2nd page and tried to swipe it back using touchpad, it closes the app launcher sometimes. It looks like the scroll event is not handled by folder itself. I will look into it.
Cc: sgabr...@chromium.org
+sgabriel@ 
Should launcher be closed on double-finger scrolling via touch pad when folder is opened?
No, vertical swipe should be disabled, horizontal scroll should scroll app pages in folder.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a107ca18d9374ea252fcc8e9e5266c9687d620ba

commit a107ca18d9374ea252fcc8e9e5266c9687d620ba
Author: Weidong Guo <weidongg@chromium.org>
Date: Wed Jun 06 22:04:35 2018

Fix mouse scroll issue in folder

Changes:
Make apps grid view in folder handles all scroll event if folder is
opened to avoid closing app launcher via scrolling up in 1st page of
folder.

Bug:  847800 
Change-Id: I5ec3744686202d519b421044d810857a3a5020d5
Reviewed-on: https://chromium-review.googlesource.com/1088148
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565052}
[modify] https://crrev.com/a107ca18d9374ea252fcc8e9e5266c9687d620ba/ui/app_list/views/apps_grid_view.cc

Status: Fixed (was: Assigned)

Sign in to add a comment