New issue
Advanced search Search tips

Issue 847796 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Autofill: Handling web sites with id collisions

Project Member Reported by olivierrobin@chromium.org, May 30 2018

Issue description

cars.com and northerntool.com (at least) present containing forms with id collision.
This breaks autofill
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50d31ff7487ef87dcd13afbee1adff2c8b750321

commit 50d31ff7487ef87dcd13afbee1adff2c8b750321
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Mon Jun 04 09:44:36 2018

[Autofill iOS] Do not use id as form identifier if there is a collision

For a form f, if document.getElementById(f.id) !== f, we cannot use the
id as the form identifier.

Bug:  847796 
Change-Id: Ib8bb5f1f2e0f990034f2f775cfc398c77d4395ea
Reviewed-on: https://chromium-review.googlesource.com/1078730
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564037}
[modify] https://crrev.com/50d31ff7487ef87dcd13afbee1adff2c8b750321/components/autofill/ios/fill/resources/form.js

Status: Fixed (was: Started)

Sign in to add a comment