Issue metadata
Sign in to add a comment
|
Replace default favicon asset |
||||||||||||||||||||||||
Issue descriptionUpdate default favicon fallback graphic used throughout our app (i.e. in collections, in Omnibox completions, etc.). The attached graphic (also found here on Drive: https://drive.google.com/open?id=16YQcGUML_VMBk-Ln4DzAgsIz1v7sdmzY&authuser=pschaffner@google.com) is drawn at 16x16pt, which is what we will want for most favicon instances throughout our app. UI Review thread: https://groups.google.com/a/google.com/d/msg/chrome-ui-review/hymZPOlxLkg/gopK4Y0-CAAJ Related Clank bug: Issue 844649
,
May 30 2018
,
May 30 2018
rohitrao@ can you triage? Unclear if this is meant for thegreenfrog@ or martijnb@
,
May 31 2018
Since the resources are final, Chris can update them in Collections. Not exactly sure where else this is being used apart from Collections and Omnibox though. stk@ could you PTAL at this for Omnibox?
,
Jun 1 2018
I don't think in omnibox completions we use this icon, instead we have a star for bookmarks or a clock for history suggestions.
,
Jun 1 2018
It'll be used in the tabstrip and tabgrid as well.
,
Jun 4 2018
stkhapugin: I think it should be used in the completions view as a replacement for the http security icon (i) that we show today, which is inaccurate and just feels like the wrong glyph to be showing in this context. Not sure if our current implementation makes it easy to show actual site favicons but even if not, it would be better to show this general fallback over what we have today IMO.
,
Jun 5 2018
pschaffner: Sorry, I don't really understand what is the context where you want to replace (i) with the favicon, let's discuss offline and file a new bug if necessary.
,
Jun 5 2018
After a short chat with Mardini, I now understand what we're talking about. You're proposing to replace the IDR_IOS_OMNIBOX_HTTP asset, which is also used by the pre-UI Refresh omnibox as a security indicator for HTTP pages. I guess you don't mean to replace the security state icon, so we could create a new asset and keep IDR_IOS_OMNIBOX_HTTP specifically for the old omnibox security status.
,
Jun 5 2018
Yeah this has nothing to do with the security indicator icon we show in the omnibox at rest. I'm speaking strictly about replacing instances of the http icon in the completions/suggestions view [in the RxR size class] with the default favicon asset (or an actual favicon if that is possible).
,
Jun 6 2018
Just to confirm, this is just for UIRefresh and we should keep the old favicon for Pre-Refresh, right?
,
Jun 6 2018
sczs: Correct.
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c048f1dd3189b2f83e22e992d36d2049da7d296f commit c048f1dd3189b2f83e22e992d36d2049da7d296f Author: Chris Lu <thegreenfrog@chromium.org> Date: Fri Jun 08 16:32:04 2018 [ios] Use World Default Favicon for FaviconLoader This will visualize the world default favicon for collections that use FaviconLoader. Bug: 847795 Change-Id: I0d0b3cfacd79bcf0510bed3b98397cc00ee57c6d Reviewed-on: https://chromium-review.googlesource.com/1089882 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#565651} [modify] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/favicon/favicon_loader.mm [modify] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/favicon/BUILD.gn [add] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/favicon/resources/BUILD.gn [rename] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/favicon/resources/default_favicon.imageset/Contents.json [rename] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/favicon/resources/default_favicon.imageset/default_favicon.png [rename] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/favicon/resources/default_favicon.imageset/default_favicon@2x.png [rename] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/favicon/resources/default_favicon.imageset/default_favicon@3x.png [rename] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/favicon/resources/default_favicon_incognito.imageset/Contents.json [rename] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/favicon/resources/default_favicon_incognito.imageset/default_favicon_incognito.png [rename] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/favicon/resources/default_favicon_incognito.imageset/default_favicon_incognito@2x.png [rename] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/favicon/resources/default_favicon_incognito.imageset/default_favicon_incognito@3x.png [add] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/favicon/resources/default_world_favicon.imageset/Contents.json [add] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/favicon/resources/default_world_favicon.imageset/default_world_favicon.png [add] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/favicon/resources/default_world_favicon.imageset/default_world_favicon@2x.png [add] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/favicon/resources/default_world_favicon.imageset/default_world_favicon@3x.png [modify] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/history_popup/BUILD.gn [modify] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/popup_menu/cells/BUILD.gn [modify] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/resources/BUILD.gn [modify] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/stack_view/BUILD.gn [modify] https://crrev.com/c048f1dd3189b2f83e22e992d36d2049da7d296f/ios/chrome/browser/ui/tabs/BUILD.gn
,
Jun 11 2018
,
Jun 12 2018
I think this still needs to be updated in the omnibox suggestions.
,
Jun 13 2018
In order to replace this in the omnibox suggestions, I'll need a 24x24 pt icon to match the other icons.
,
Jun 15 2018
See issue 821817 for assets + specs for drawing icons in the completion cells.
,
Jun 25 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by pschaffner@chromium.org
, May 30 2018