"external/wpt/service-workers/service-worker/fetch-event.https.html" is flaky |
|||||
Issue description"external/wpt/service-workers/service-worker/fetch-event.https.html" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTQsSBUZsYWtlIkJleHRlcm5hbC93cHQvc2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyL2ZldGNoLWV2ZW50Lmh0dHBzLmh0bWwM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs This flaky test/step was previously tracked in issue 807014 .
,
Jun 4 2018
CL to update test expectations is in CQ.
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a51c1c9eb2cc0558cdab8536504ebf8f4e71295 commit 7a51c1c9eb2cc0558cdab8536504ebf8f4e71295 Author: Dominic Battre <battre@chromium.org> Date: Mon Jun 04 12:38:49 2018 Update test expectations of several LayoutTests TBR=battre@chromium.org Bug: 847565 , 831686 , 829952, 847870 , 847787 , 847697 Change-Id: I09868efd7e48a809dcdbdc17c1a548cc7003814f Reviewed-on: https://chromium-review.googlesource.com/1084842 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#564067} [modify] https://crrev.com/7a51c1c9eb2cc0558cdab8536504ebf8f4e71295/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 4 2018
,
Jun 4 2018
,
Jun 4 2018
The test is just flakily timing out because it is too heavy. It should be split up.
,
Jun 5 2018
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf5d61ae5a100fe7dfca2f26330b4798fffd9bc5 commit bf5d61ae5a100fe7dfca2f26330b4798fffd9bc5 Author: Matt Falkenhagen <falken@chromium.org> Date: Wed Jun 06 02:32:03 2018 Make fetch-event.https.html faster. It was registering a service worker for each test case, and had a lot of test cases. This changes the file to register a single service worker at the beginning, and unregister it at the end. Bug: 847787 Change-Id: Ic2536824a3c57e86bb5e042287e9e62e6222ad9a Reviewed-on: https://chromium-review.googlesource.com/1087188 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#564770} [modify] https://crrev.com/bf5d61ae5a100fe7dfca2f26330b4798fffd9bc5/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/bf5d61ae5a100fe7dfca2f26330b4798fffd9bc5/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event.https-expected.txt [modify] https://crrev.com/bf5d61ae5a100fe7dfca2f26330b4798fffd9bc5/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event.https.html
,
Jun 6 2018
It looks like the times on dbg got a bit faster. The test is still slow though, taking a up to ~10 sec on dbg. If it times out again I can split up the test file more.
,
Jun 6 2018
Maybe we should just note that this test needs a longer timeout by adding: <meta name=timeout content=long> I believe the WPT harness will then extend the timeout period. Of course, I don't know if the blink test infrastructure has its own timeout that would also need to be extended.
,
Jun 6 2018
Re 10#: yes that's supported in both WPT upstream and within Blink. Nit: there are quotes around the values: <meta name="timeout" content="long"> |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by battre@chromium.org
, Jun 4 2018Owner: kinuko@chromium.org