New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847777 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

48% regression in thread_times.key_idle_power_cases at 562234:562282

Project Member Reported by kraynov@chromium.org, May 30 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, May 30 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=847777

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=cd02262c3e8b7f276711416882b02b773f7ae359e7fd197a5c4680aa725b01a2


Bot(s) for this bug's original alert(s):

android-nexus5
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 30 2018

Cc: gab@chromium.org
Owner: gab@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/149f247a240000

[TaskScheduler] Slower latency heartbeat by gab@chromium.org
https://chromium.googlesource.com/chromium/src/+/7e7dd55cce56f643d5945f5a2dbd42d475c73e1b

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by gab@chromium.org, May 31 2018

Cc: sullivan@chromium.org
Labels: -Performance-Sheriff
Owner: skyos...@chromium.org
This is actually an improvement (fix to  issue 845919 ). The metric is "unitless" and as such has "(? is better)" and treats both improvements and regressions as regressions...

@skyostil as metric owner to fix units

Comment 5 by sullivan@google.com, May 31 2018

Owner: eakuefner@chromium.org
Thanks, gab!

Ethan, can you take a look? I suspect the HistogramSet migration may have confused the units here.

Comment 6 by gab@chromium.org, Jun 1 2018

 Issue 847404  has been merged into this issue.

Comment 7 by gab@chromium.org, Jun 1 2018

 Issue 847988  has been merged into this issue.
Status: Started (was: Assigned)
I'll pick this up, just a missing entry in legacy_unit_info.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/caee0de0ecc8b6065dd5e8ee4ef352f594dac2bc

commit caee0de0ecc8b6065dd5e8ee4ef352f594dac2bc
Author: Ethan Kuefner <eakuefner@chromium.org>
Date: Fri Jun 01 23:06:34 2018

[TBMv2] Add 'tasks' legacy_unit_info

This CL copies the unit info for 'tasks' out of unit-info.json.

https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/value/unit-info.json?l=204&rcl=b48f5b49150fee6571e073e435926cadb8d50487

Bug:  chromium:847777 
Change-Id: I3bf468bd4c640b8e9147e8fa5b1c39714a15bbd1
Reviewed-on: https://chromium-review.googlesource.com/1083673
Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>

[modify] https://crrev.com/caee0de0ecc8b6065dd5e8ee4ef352f594dac2bc/tracing/tracing/value/legacy_unit_info.html

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d0a9e824d130652cabd1869b367013c94698ca8

commit 7d0a9e824d130652cabd1869b367013c94698ca8
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Jun 02 01:03:24 2018

Roll src/third_party/catapult b26b30d..caee0de (1 commits)

https://chromium.googlesource.com/catapult.git/+log/b26b30d..caee0de


git log b26b30d..caee0de --date=short --no-merges --format='%ad %ae %s'
2018-06-01 eakuefner@chromium.org [TBMv2] Add 'tasks' legacy_unit_info


Created with:
  gclient setdep -r src/third_party/catapult@caee0de

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:847777 
TBR=sullivan@chromium.org

Change-Id: I9d6041c4680522a6d71fb26d7a9dde91e331c2c5
Reviewed-on: https://chromium-review.googlesource.com/1083851
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#563893}
[modify] https://crrev.com/7d0a9e824d130652cabd1869b367013c94698ca8/DEPS

Status: Verified (was: Started)
This is fixed, as seen on the linked group_report.

Sign in to add a comment