New issue
Advanced search Search tips

Issue 847767 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Presubmit: Ignore holes in policy id space for merge CLs

Project Member Reported by pmarko@chromium.org, May 30 2018

Issue description

Skip the _CheckPolicyIDs[1] check if the CL is a merge CL.

--
Rationale:
_CheckPolicyIDs[1] comment says:
Holes would not be a technical problem, but we want to ensure that nobody accidentally omits IDs.

It only makes sense to ensure this on master. When merging back, it's possible to leave out policies that are not being merged back.

--
How:
Check the remote branch, skip the check if it is not origin/master.

[1] https://cs.chromium.org/chromium/src/components/policy/tools/syntax_check_policy_template_json.py?rcl=554991dec6dc951153addfa064f4c7f18cc9cbac&l=149





 

Sign in to add a comment