New issue
Advanced search Search tips

Issue 847763 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Incorrect UA styling of form inside table elements

Project Member Reported by futhark@chromium.org, May 30 2018

Issue description

Default styling for forms inside table elements according to [1] is:

:matches(table, thead, tbody, tfoot, tr) > form { display: none !important; }

and only in html documents.

[1] https://html.spec.whatwg.org/multipage/rendering.html#tables-2

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cc5d1b3afcbf778e5e1655731716f4b7b496131

commit 9cc5d1b3afcbf778e5e1655731716f4b7b496131
Author: Rune Lillesveen <futhark@chromium.org>
Date: Wed May 30 10:35:48 2018

[Squad] Use UA styling for form inside table elements.

We did not implement UA style as specified for form elements inside
table elements. This CL removes the hardcoded way of not creating layout
objects and instead add display:none to the UA style sheet as specified.

We introduce a new internal pseudo class :-internal-is-html because the
rule should only apply in html documents. This is also what Gecko does
with its :-moz-is-html. The pseudo class is only allowed in UA sheets.

The relationship with Squad is that we get rid of the dependency on
ancestor layout objects in LayoutObjectIsNeeded.

Bug:  847763 ,  843520 
Change-Id: Ibc83b78493843b1a0503fbb65e509090fe295313
Reviewed-on: https://chromium-review.googlesource.com/1078348
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562789}
[add] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/WebKit/LayoutTests/external/wpt/html/rendering/non-replaced-elements/tables/form-in-tables.html
[add] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/WebKit/LayoutTests/external/wpt/html/rendering/non-replaced-elements/tables/form-in-tables.xhtml
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/css/css_selector.cc
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/css/css_selector.h
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/css/html.css
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/css/parser/css_proto_converter.cc
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/css/parser/css_selector_parser_test.cc
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/css/rule_feature_set.cc
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/css/selector_checker.cc
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/html/forms/html_form_element.cc
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/html/forms/html_form_element.h
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/html/parser/html_construction_site.cc
[modify] https://crrev.com/9cc5d1b3afcbf778e5e1655731716f4b7b496131/third_party/blink/renderer/core/inspector/inspector_trace_events.cc

Status: Fixed (was: Started)

Sign in to add a comment