New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847759 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Compat



Sign in to add a comment

Canvas differs when hardware acceleration is enabled

Reported by fun07.ma...@gmail.com, May 30 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36

Example URL:
https://marci4.github.io/chromecanvasgpuvscpu/canvasgpuvscpu.html

Steps to reproduce the problem:
1. Enable hardware acceleration
2. Visit site

What is the expected behavior?
The site looks the same both with hardware acceleration enabled and disabled

What went wrong?
See marked differences in the GPU.png

Does it occur on multiple sites: N/A

Is it a problem with a plugin? N/A 

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 66.0.3359.181  Channel: stable
OS Version: 10.0
Flash Version:
 
GPU.PNG
56.6 KB View Download
CPU.PNG
78.0 KB View Download
chrome_gpu.txt
13.7 KB View Download
GPU0.PNG
18.6 KB View Download
GPU1.PNG
18.6 KB View Download
Was able to reproduce it also in Canary 69.0.3445.0
Components: Blink>Canvas
Labels: Needs-Triage-M66
Cc: phanindra.mandapaka@chromium.org
Labels: Triaged-ET M-69 Target-69 FoundIn-69 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on reported chrome version 66.0.3359.181 & latest stable 67.0.3396.62  and on latest chrome 69.0.3446.0 using ,Windows 10, Mac 10.13.1 and ubuntu 14.04. 
 
Same behavior is seen on M60(60.0.3112.113) hence considering it as non-regression and marking it as Untriaged.


Thanks! 

Comment 5 by junov@chromium.org, Jun 21 2018

Components: Internals>Skia
Owner: senorblanco@chromium.org
Status: Assigned (was: Untriaged)
Looks like an issue with skia's gpu-accelerated path rendering.
Owner: bsalomon@chromium.org
I wasn't able to repro this on my devices (Ubuntu, Win, Mac). It also didn't seem to be using the tessellating path renderers. Perhaps it's an oval-drawing issue?

Handing over to Brian for further triage.
Here is another example https://marci4.github.io/chromecanvasgpuvscpu/canvasgpuvscpucirclee.html 
CPU.PNG
2.8 KB View Download
GPU.PNG
2.5 KB View Download
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/3ac1f959878418828044a5ebbaa42d1298940d0b

commit 3ac1f959878418828044a5ebbaa42d1298940d0b
Author: Brian Salomon <bsalomon@google.com>
Date: Fri Sep 07 20:21:24 2018

Preseve tangents when converting cubics->quads in GrAAHairlinePathRenderer

Bug:  chromium:847759 
Change-Id: I35a6d069f732d906714a640fca59a71fd35b74ec
Reviewed-on: https://skia-review.googlesource.com/152664
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>

[modify] https://crrev.com/3ac1f959878418828044a5ebbaa42d1298940d0b/gn/gm.gni
[add] https://crrev.com/3ac1f959878418828044a5ebbaa42d1298940d0b/gm/crbug_847759.cpp
[modify] https://crrev.com/3ac1f959878418828044a5ebbaa42d1298940d0b/src/gpu/GrPathUtils.h
[modify] https://crrev.com/3ac1f959878418828044a5ebbaa42d1298940d0b/src/gpu/GrPathUtils.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5e69f489d9728630b34a155d5193fea99c25ac2

commit d5e69f489d9728630b34a155d5193fea99c25ac2
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Sep 07 23:23:32 2018

Roll src/third_party/skia 24de64834600..24e8f58cfa9c (11 commits)

https://skia.googlesource.com/skia.git/+log/24de64834600..24e8f58cfa9c


git log 24de64834600..24e8f58cfa9c --date=short --no-merges --format='%ad %ae %s'
2018-09-07 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader a062f321768d..3655209d86f4 (1 commits)
2018-09-07 reed@google.com Revert "Revert "add flag to soften the blow of removing a legacy api for flutter""
2018-09-07 bsalomon@google.com Preseve tangents when converting cubics->quads in GrAAHairlinePathRenderer
2018-09-07 borenet@google.com [infra] Revert broken recipe rolls, add test for missing patch_ref
2018-09-07 brianosman@google.com Add support for gray + colorspace to SkCodec
2018-09-07 bungeman@google.com Simplify FreeType glyph bounds.
2018-09-07 caryclark@google.com reland fix picture subclass destructor doc
2018-09-07 mtklein@google.com add clamp_gamut
2018-09-07 jvanverth@google.com Revert "add flag to soften the blow of removing a legacy api for flutter"
2018-09-07 borenet@google.com Add new autoroll service accounts to AUTHORS check bypass
2018-09-07 mtklein@google.com remove -k 0 from builds


Created with:
  gclient setdep -r src/third_party/skia@24e8f58cfa9c

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:847759 
TBR=jvanverth@chromium.org

Change-Id: I5346f6bf867e5501abfe07bf4f1a78db070605b9
Reviewed-on: https://chromium-review.googlesource.com/1213446
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589716}
[modify] https://crrev.com/d5e69f489d9728630b34a155d5193fea99c25ac2/DEPS

Status: Fixed (was: Assigned)

Sign in to add a comment