New issue
Advanced search Search tips

Issue 847757 link

Starred by 2 users
Status: Fixed
Owner:
jonasolsson@chromium.org
Closed: May 2018
Cc:
abdulsyed@google.com
maxmorin@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Audio-Service


Sign in to add a comment

Add UMA disconnect stat for audio streams

Project Member Reported by jonasolsson@chromium.org, May 30 2018 
When an Audio[In|Out]putStreamBroker is destroyed, make a best-effort attempt to track why it happened.

We track the following categories:
 * Various forms of platform error.
 * The client explicitly reset the stream.
 * Failure during stream creation.
 * The broker was destroyed without other error, presumably because the surrounding context is going away.
 * Finally, if we don't get an explicit reason we assume the audio service crashed.
Project Member

Comment 1 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4

commit 9fafb29ac55e80bb1290743cb5a50dbd70aee0b4
Author: Jonas Olsson <jonasolsson@chromium.org>
Date: Thu May 31 15:07:55 2018

Add UMA stats about audio stream broker disconnect reasons.

Bug:  847757 
Change-Id: Id22976c47dbfd65db2fb8bbaadca2a2c3bb0d368
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1069132
Commit-Queue: Jonas Olsson <jonasolsson@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563232}
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/content/browser/media/audio_input_stream_broker.cc
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/content/browser/media/audio_input_stream_broker.h
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/content/browser/media/audio_output_stream_broker.cc
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/content/browser/media/audio_output_stream_broker.h
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/content/browser/media/audio_output_stream_broker_unittest.cc
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/content/renderer/media/mojo_audio_output_ipc.cc
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/content/renderer/media/mojo_audio_output_ipc_unittest.cc
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/media/mojo/interfaces/audio_input_stream.mojom
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/media/mojo/interfaces/audio_output_stream.mojom
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/media/mojo/services/mojo_audio_output_stream_provider.cc
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/services/audio/input_stream.cc
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/services/audio/input_stream.h
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/services/audio/output_stream.cc
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/services/audio/output_stream_unittest.cc
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/9fafb29ac55e80bb1290743cb5a50dbd70aee0b4/tools/metrics/histograms/histograms.xml

Comment 2 by jonasolsson@chromium.org, May 31 2018

Status: Fixed (was: Started)

Comment 3 by maxmorin@chromium.org, Jun 4 2018

Labels: Target-68 M-68 Merge-Request-68 OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows
Requesting merge of these UMA stats to M68, since they will help us to evaluate the new audio service.

Comment 4 by abdulsyed@google.com, Jun 4 2018

Labels: -Merge-Request-68 Merge-Approved-68
Approved - branch:3440
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 8 2018

Cc: abdulsyed@google.com maxmorin@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 11 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b977f95a1c71edc988e7671711a122d23f03fe76

commit b977f95a1c71edc988e7671711a122d23f03fe76
Author: Jonas Olsson <jonasolsson@chromium.org>
Date: Mon Jun 11 07:11:25 2018

[M68] Add UMA stats about audio stream broker disconnect reasons.

Bug:  847757 
Change-Id: Id22976c47dbfd65db2fb8bbaadca2a2c3bb0d368
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1069132
Commit-Queue: Jonas Olsson <jonasolsson@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563232}(cherry picked from commit 9fafb29ac55e80bb1290743cb5a50dbd70aee0b4)
Reviewed-on: https://chromium-review.googlesource.com/1095015
Cr-Commit-Position: refs/branch-heads/3440@{#271}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/content/browser/media/audio_input_stream_broker.cc
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/content/browser/media/audio_input_stream_broker.h
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/content/browser/media/audio_output_stream_broker.cc
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/content/browser/media/audio_output_stream_broker.h
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/content/browser/media/audio_output_stream_broker_unittest.cc
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/content/renderer/media/mojo_audio_output_ipc.cc
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/content/renderer/media/mojo_audio_output_ipc_unittest.cc
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/media/mojo/interfaces/audio_input_stream.mojom
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/media/mojo/interfaces/audio_output_stream.mojom
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/media/mojo/services/mojo_audio_output_stream_provider.cc
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/services/audio/input_stream.cc
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/services/audio/input_stream.h
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/services/audio/output_stream.cc
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/services/audio/output_stream_unittest.cc
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/b977f95a1c71edc988e7671711a122d23f03fe76/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment