Regression : Radio button's focus ring appears misplaced in ''Popups blocked" bubble for "Arabic" language.
Reported by
avsha...@etouch.net,
May 30 2018
|
||
Issue descriptionChrome Version : 68.0.3440.7 (Official Build) 9bbd2d0687bd83181f22ac13565501690ee5b4c7-refs/branch-heads/3440@{#16} (32/64 Bit) OS : Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.5), Linux 14.04 LTS Precondition : Change browser language to "Arabic" from chrome://settings/languages and relaunch. What steps will reproduce the problem? 1. After relaunch, open NTP and navigate to https://permission.site/ 2. Click on "Popup (Delayed 2 seconds)" button such that 'Popups blocked' bubble appears in omnibox. 3. Open 'Popups blocked' bubble and press 'Tab' key twice and observe the blue focus ring. Actual Result : Radio button's focus ring appears misplaced in ''Popups blocked" bubble for "Arabic" language. Expected Result : Focus ring should appear properly for radio button in ''Popups blocked" bubble, for "Arabic" language. This is a regression issue broken in M-68 and below is the bisect info: Good Build : 68.0.3436.0 (Revision : 560158) Bad Build : 68.0.3437.0 (Revision : 560453) Change log URL : https://chromium.googlesource.com/chromium/src/+log/4722f442b82deb3620f6c149a806135e44342817..824d232c3d3630d9486a33f3cbc9be6077654c40 Suspect : https://chromium.googlesource.com/chromium/src/+/824d232c3d3630d9486a33f3cbc9be6077654c40 @Elly : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : 1. Able to reproduce this issue on Canary build #69.0.3445.0 as well 2. Issue can also be reproduced with 'Hebrew' language.
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e49b57b9722f6ae3022156f3344ca5f419ddb00 commit 7e49b57b9722f6ae3022156f3344ca5f419ddb00 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu May 31 14:10:02 2018 views: flip focus ring bounds for checkbox and radiobutton Bug: 847746 Change-Id: Ic7096b63241419da315a6fe21d85459c6723c266 Reviewed-on: https://chromium-review.googlesource.com/1078945 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#563216} [modify] https://crrev.com/7e49b57b9722f6ae3022156f3344ca5f419ddb00/ui/views/controls/button/checkbox.cc [modify] https://crrev.com/7e49b57b9722f6ae3022156f3344ca5f419ddb00/ui/views/controls/button/radio_button.cc [modify] https://crrev.com/7e49b57b9722f6ae3022156f3344ca5f419ddb00/ui/views/controls/focus_ring.h
,
May 31 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by ellyjo...@chromium.org
, May 30 2018