Patch "Relativize include dir for windows build" cause gn gen failed on windows |
|||||
Issue description
I have my visual studio in C:\ and chromium project in D:\
and this patch cause gn gen failed with errors like : Generating files...
Traceback (most recent call last):
File "D:/workspace/shaobo/chrome/src/build/toolchain/win/setup_toolchain.py", line 274, in <module>
main()
File "D:/workspace/shaobo/chrome/src/build/toolchain/win/setup_toolchain.py", line 245, in main
include = map(os.path.relpath, include)
File "D:\workspace\depot_tools\win_tools-2_7_6_bin\python\bin\lib\ntpath.py", line 512, in relpath
Traceback (most recent call last):
File "D:/workspace/shaobo/chrome/src/build/toolchain/win/setup_toolchain.py", line 274, in <module>
main()
File "D:/workspace/shaobo/chrome/src/build/toolchain/win/setup_toolchain.py", line 245, in main
% (path_prefix, start_prefix))
include = map(os.path.relpath, include)
ValueError File "D:\workspace\depot_tools\win_tools-2_7_6_bin\python\bin\lib\ntpath.py", line 512, in relpath
: p% (path_prefix, start_prefix))
ath is on drive C:, start on drive D:ValueError
: path is on drive C:, start on drive D:
,
May 31 2018
,
May 31 2018
,
May 31 2018
Let me make a fix for different drive.
,
May 31 2018
tikuta@, thx !
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bee3633680db062b91d1d36e2911f13572284ed commit 3bee3633680db062b91d1d36e2911f13572284ed Author: Takuto Ikuta <tikuta@chromium.org> Date: Thu May 31 04:06:48 2018 win: check drive letter before relativize include path Bug: 847738 Change-Id: I49a8cbcaad484f8044a0196901b8cf6140b39388 Reviewed-on: https://chromium-review.googlesource.com/1080357 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#563148} [modify] https://crrev.com/3bee3633680db062b91d1d36e2911f13572284ed/build/toolchain/win/setup_toolchain.py
,
May 31 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by shaobo....@intel.com
, May 30 2018