New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847733 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Page turns blank on rotating pdf multiple times.

Reported by shruti.j...@etouch.net, May 30 2018

Issue description

Chrome version: 68.0.3440.7 (Official Build) Revision 9bbd2d0687bd83181f22ac13565501690ee5b4c7-refs/branch-heads/3440@{#16}(64-bit)

OS:Mac OS X(10.12.6,10.13.1,10.13.5)

Steps to reproduce:
1. Launch chrome, crash the browser using 'chrome://inducebrowsercrashforrealz' 
2. After relaunch click on restore button and navigate to google.com and search for 'test pdf'.
3. Open the first link shown in the result.
4. Click on rotate icon multiple times shown in toolbar and observe.

Actual Result: Page turns blank on rotating pdf multiple times.
Expected Result: Pdf should appear properly even after multiple rotation.

This is regression issue broken in ‘M-68’ and providing per-revision bisect info below:
Good Build:68.0.3439.0(Revision:561389)  
Bad Build:68.0.3440.0(Revision:561733)

You are probably looking for a change made after 561614 (known good), but no later than 561615 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/e257d3b0b2ce380369dc8c0038fa2304cf251cca..4255c18dd8d9b3411e6cdbaa92782c4cf2a97581

Suspect:https://chromium.googlesource.com/chromium/src/+/4255c18dd8d9b3411e6cdbaa92782c4cf2a97581

@Fady Samuel: Could you please help to reassign if your change is not the cause for this change.

Note:
1.Issue is only  reproducible on MAC(10.12.6,10.13.1,10.13.5) OS.
2.Issue is also reproducible on latest canary M69# 69.0.3444.0.

Kindly review the attached screen-cast .
Thank You!



 
Actual Result.mov
5.0 MB View Download
Expected Result.mov
4.9 MB View Download
I can repro this without rotation. My immediate suspicion is the content rendering timeout is firing for some reason.
Cc: manoranj...@chromium.org
Labels: ReleaseBlock-Stable
marking as RBS, please change if required.
I cannot repro this anymore... it somehow got fixed although I think it might still be in M68. I'll investigate further later today.
Friendly ping to get an update on this issue as it is marked as RBS.
Thanks..!
Bulk update: M68 stable cut is scheduled for July 19th. This issue is marked as RB-Stable, so please take a look at it before. Thanks!
any updates on this fsamuel@
Is this still occurring in M68?
Ahh I lost track of this bug...trying it out now on M68.
Looks like this is the fix: https://chromium-review.googlesource.com/c/chromium/src/+/1109448

This landed in M69 but was not merged in M68. Shall I merge back?
Cc: ccameron@chromium.org
+ccameron
How safe is this fix overall?
I would say quite safe. 
Gentle ping to get an update on this issue as it is marked as RBS for M68 & M68 stable release is coming this week.
Thanks..!
Labels: M-69
Labels: -M-68 -Target-68
Let's punt this to M69. 
Gentle ping to get an update on this issue as it is marked as RBS.
Thanks..!
Just to update:
Still seeing the same issue on latest stable-68.0.3440.84 as per C#0.
 
fsamuel@, Please take a look and update as it is marked as RBS.
Thanks..!
M69 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
Per comment #9, this change is already landed in M69. Pls confirm and mark bug as fixed if nothing else is pending.
Status: Fixed (was: Assigned)
This is already in M69 so there's nothing to do here.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD

Sign in to add a comment