New issue
Advanced search Search tips

Issue 847728 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

DCHECK failure in !IsSmi() == Internals::HasHeapObjectTag(this) in objects.h

Project Member Reported by ClusterFuzz, May 30 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5689055099224064

Fuzzer: v8_builtins_generator
Job Type: linux_asan_d8_v8_mipsel_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  !IsSmi() == Internals::HasHeapObjectTag(this) in objects.h
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_v8_mipsel_dbg&range=53408:53409

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5689055099224064

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 30 2018

Labels: Test-Predator-Auto-Owner
Owner: jgruber@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/757631830d253269ffb90dd10ce9f75265a2cdbc ([masm] Don't push CodeObject when entering INTERNAL frames).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Nice find as always. The mips/mips64 ports in that CL were incomplete and mess up sp/fp offsets. Fixing.
Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/faa18098d01f530d572e79ff32fd7463e4d54744

commit faa18098d01f530d572e79ff32fd7463e4d54744
Author: jgruber <jgruber@chromium.org>
Date: Wed May 30 10:28:12 2018

[mips,mips64] Fix sp and fp offsets for INTERNAL frames

https://crrev.com/c/1075047 introduced a bug on mips/mips64 in which
sp and fp offsets were set incorrectly for INTERNAL frames.

Bug:  v8:6666 , chromium:847728 , chromium:847568 
Change-Id: I9a48d30a82f10a4af50f1ed4dc1d77e8defbdd77
Reviewed-on: https://chromium-review.googlesource.com/1078109
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53434}
[modify] https://crrev.com/faa18098d01f530d572e79ff32fd7463e4d54744/src/mips/macro-assembler-mips.cc
[modify] https://crrev.com/faa18098d01f530d572e79ff32fd7463e4d54744/src/mips64/macro-assembler-mips64.cc

Cc: mstarzinger@chromium.org
Labels: Pri-1
Status: Fixed (was: Assigned)
Project Member

Comment 5 by sheriffbot@chromium.org, May 30 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 6 by ClusterFuzz, May 31 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5812828641165312 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 7 by ClusterFuzz, May 31 2018

ClusterFuzz has detected this issue as fixed in range 53433:53434.

Detailed report: https://clusterfuzz.com/testcase?key=5689055099224064

Fuzzer: v8_builtins_generator
Job Type: linux_asan_d8_v8_mipsel_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  !IsSmi() == Internals::HasHeapObjectTag(this) in objects.h
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_v8_mipsel_dbg&range=53408:53409
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_v8_mipsel_dbg&range=53433:53434

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5689055099224064

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 5

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment