New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 847704 link

Starred by 2 users
Status: WontFix
Owner:
█ mgiuca@chromium.org
Long OOO (go/where-is-mgiuca)
Closed: Jun 2018
Cc:
█ loonyb...@chromium.org
tapted@chromium.org
█ pilgrim@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: All/PasswordManagerBrowserTestWithConditionalPopupViews.AutofillBaseTagWithNoActionTest/1



Sign in to add a comment

All/PasswordManagerBrowserTestWithConditionalPopupViews.AutofillBaseTagWithNoActionTest/1 is Flaky

Project Member Reported by Findit, May 30 2018 
Findit has detected a flake at test All/PasswordManagerBrowserTestWithConditionalPopupViews.AutofillBaseTagWithNoActionTest/1.

Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/I486df02edd2d762c0a0f93449d47aafdf5337f27
Regression range: None

Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy9QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCK-AWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bU9TIE1TYW4gVGVzdHMvNzM1OS9pbnRlcmFjdGl2ZV91aV90ZXN0cy9RV3hzTDFCaGMzTjNiM0prVFdGdVlXZGxja0p5YjNkelpYSlVaWE4wVjJsMGFFTnZibVJwZEdsdmJtRnNVRzl3ZFhCV2FXVjNjeTVCZFhSdlptbHNiRUpoYzJWVVlXZFhhWFJvVG05QlkzUnBiMjVVWlhOMEx6RT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

If this result was incorrect, apply the label Test-Findit-Wrong, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
Project Member

Comment 1 by Findit, May 30 2018 

Findit identified the culprit r561966 with confidence 70.0% in the config "chromium.memory / Linux ChromiumOS MSan Tests"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy9QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCK-AWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bU9TIE1TYW4gVGVzdHMvNzM1OS9pbnRlcmFjdGl2ZV91aV90ZXN0cy9RV3hzTDFCaGMzTjNiM0prVFdGdVlXZGxja0p5YjNkelpYSlVaWE4wVjJsMGFFTnZibVJwZEdsdmJtRnNVRzl3ZFhCV2FXVjNjeTVCZFhSdlptbHNiRUpoYzJWVVlXZFhhWFJvVG05QlkzUnBiMjVVWlhOMEx6RT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Comment 2 by mgiuca@chromium.org, Jun 4 2018 

 Issue 848728  has been merged into this issue.

Comment 3 by mgiuca@chromium.org, Jun 4 2018 

 Issue 848742  has been merged into this issue.

Comment 4 by mgiuca@chromium.org, Jun 4 2018 

 Issue 848889  has been merged into this issue.

Comment 5 by mgiuca@chromium.org, Jun 4 2018

Cc: tapted@chromium.org pilgrim@chromium.org loonyb...@chromium.org
Owner: mgiuca@chromium.org
Status: WontFix (was: Available)
Note that the above 3 dupes each had their own Findit analysis and they all came back blaming the exact same commit:

Findit identified the culprit r561966 with confidence 70.0% in the config "chromium.memory / Linux ChromiumOS MSan Tests"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy6QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKyAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bU9TIE1TYW4gVGVzdHMvNzM5MS9pbnRlcmFjdGl2ZV91aV90ZXN0cy9RV3hzTDFCaGMzTjNiM0prVFdGdVlXZGxja0p5YjNkelpYSlVaWE4wVjJsMGFFTnZibVJwZEdsdmJtRnNVRzl3ZFhCV2FXVjNjeTVCZFhSdlptbHNiRXh2WjJsdVUybG5iblZ3Um05eWJTOHcMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Findit identified the culprit r561966 with confidence 70.0% in the config "chromium.memory / Linux ChromiumOS MSan Tests"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy8QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCK6AWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bU9TIE1TYW4gVGVzdHMvNzM5MS9pbnRlcmFjdGl2ZV91aV90ZXN0cy9RV3hzTDFCaGMzTjNiM0prVFdGdVlXZGxja0p5YjNkelpYSlVaWE4wVjJsMGFFTnZibVJwZEdsdmJtRnNVRzl3ZFhCV2FXVjNjeTVCZFhSdlptbHNiRkJoYzNOM2IzSmtUbTlHYjNKdFJXeGxiV1Z1ZEM4eAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

Findit identified the culprit r561966 with confidence 70.0% in the config "chromium.memory / Linux ChromiumOS MSan Tests"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy6QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKyAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bU9TIE1TYW4gVGVzdHMvNzM5NC9pbnRlcmFjdGl2ZV91aV90ZXN0cy9RV3hzTDFCaGMzTjNiM0prVFdGdVlXZGxja0p5YjNkelpYSlVaWE4wVjJsMGFFTnZibVJwZEdsdmJtRnNVRzl3ZFhCV2FXVjNjeTVCZFhSdlptbHNiRXh2WjJsdVUybG5iblZ3Um05eWJTOHgMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

I'm very confused because r561966 is a) a revert, and b) nothing to do with password manager. It's possible changing something in assist_ranker broke password manager.

Anyway, we can't revert it, because it's already been re-landed (effectively, r561966 has already been "reverted" by re-landing):

- r561845: Original CL to "Migrate AssistRanker to SimpleURLLoader"
- r561966: Revert of r561845; apparently because original caused RankerModelLoaderImplTest to fail. This is the culprit identified above.
- r562806: Reland of r561845.

Unfortunately, Findit doesn't have any data from before r561845 or after r562806, so we're a bit blind as to whether the reland fixed this. However, I can't find a mention of PasswordManagerBrowserTestWithConditionalPopupViews in Flakiness Dashboard. So I'm going to assume this is fixed. Closing.
►

Sign in to add a comment