New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847689 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature



Sign in to add a comment

Update recommended min UA Resource Timing buffer size to 250

Reported by nicjan...@gmail.com, May 30 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36

Steps to reproduce the problem:
See https://github.com/w3c/resource-timing/pull/155

What is the expected behavior?

What went wrong?
The Chrome "default" buffer size should be increased from 150 to 250 per proposed spec update.

Did this work before? No 

Does this work in other browsers? N/A

Chrome version: 66.0.3359.181  Channel: n/a
OS Version: 10.0
Flash Version:
 
Labels: Needs-Triage-M66

Comment 2 by y...@yoav.ws, May 30 2018

Cc: y...@yoav.ws
Labels: -Type-Bug Triaged-ET M-69 Target-69 FoundIn-69 Type-Feature
Status: Untriaged (was: Unconfirmed)
As per comment #0, it seems to be a feature request. Hence, marking it as utriaged for further inputs from dev team.

Thanks...!!

Comment 4 by y...@yoav.ws, May 30 2018

Cc: -y...@yoav.ws
Owner: y...@yoav.ws
Status: started (was: Untriaged)
Started work at https://chromium-review.googlesource.com/c/chromium/src/+/1078107
Project Member

Comment 5 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e52fcc1d97398a63cc876bd7f3e79b409b1042a7

commit e52fcc1d97398a63cc876bd7f3e79b409b1042a7
Author: Yoav Weiss <yoav@yoav.ws>
Date: Thu May 31 02:53:10 2018

Change Resource Timing default buffer size to 250.

Following a proposed spec change[1], this CL changes the number of entries
buffered by default before the Resource Timing buffer is full.

[1] https://github.com/w3c/resource-timing/pull/155

Bug:  847689 
Change-Id: Id93bfea902b0cf049abdac12a98cc4fba7ff1dd3
Reviewed-on: https://chromium-review.googlesource.com/1078107
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#563133}
[add] https://crrev.com/e52fcc1d97398a63cc876bd7f3e79b409b1042a7/third_party/WebKit/LayoutTests/external/wpt/resource-timing/resource_timing_buffer_full_eventually.html
[add] https://crrev.com/e52fcc1d97398a63cc876bd7f3e79b409b1042a7/third_party/WebKit/LayoutTests/http/tests/performance-timing/resource_timing_buffer_full_250.html
[modify] https://crrev.com/e52fcc1d97398a63cc876bd7f3e79b409b1042a7/third_party/blink/renderer/core/timing/performance.cc

Comment 6 by y...@yoav.ws, Jun 1 2018

Status: Fixed (was: Started)

Sign in to add a comment