New issue
Advanced search Search tips

Issue 847688 link

Starred by 5 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Sep 20
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
M-X

Blocking:
issue 822061
issue 846430



Sign in to add a comment

Crossfade tab title/alert indicator while close button is fading in/out

Project Member Reported by pkasting@chromium.org, May 30 2018

Issue description

Currently we snap the tab title/alert indicator over to leave room for the close button whenever it's at all visible.  This looks super janky.

I tried animating the bounds over.  This only helps marginally, and only if the close button animation is the right speed.

I think we need to crossfade instead.  To do this, Tab::PaintChildren() has to actually paint all the children manually so it can implement the crossfading, and we need duplicate tab title/alert indicator members used only for crossfading.  The "real" members (children used in hittesting) should continue to be laid out as today; the paint-only members should be laid out based on there being no close button.  Then PaintChildren() can just alpha-blend between the two sets.
 
Blocking: 846430
Labels: Pri-1
Triage: Upgrading to P1 - Flicker or movement now meets the P1 bar.
Cc: markchang@chromium.org pkasting@chromium.org
Labels: -Pri-1 Pri-3
Moving this to P3 since the close button is being turned back on.
Yep, this is only useful/necessary when disabling close buttons on inactive tabs.
Labels: Group-Tabstrip
Status: WontFix (was: Available)
Since close buttons always show for the common case, this is less of an issue now.
Status: Available (was: WontFix)
It's less of an issue, but (a) it's still going to be an issue on single tabs, and (b) we still have the flag to hide close buttons on all tabs, so until both of those aren't true, I'd like to leave it open as P3.
Labels: M-X
Status: WontFix (was: Available)
I'm in the process of killing both these flags.

Sign in to add a comment