when response is in JSONPB format, the field names in a fieldmask must use camelCase. Update https://cs.chromium.org/chromium/infra/luci/appengine/components/components/protoutil/field_masks.py to support camelCase. This does not affect clients that use binary encoding
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/25779f2c9fc7f73329dad666de9d273f386392d8 commit 25779f2c9fc7f73329dad666de9d273f386392d8 Author: Nodir Turakulov <nodir@google.com> Date: Wed May 30 18:58:26 2018 [protoutil] field masks: add support for JSONPB JSONPB uses lowerCamelCase for field names. Add support for field masks that use it. Bug: 847687 Change-Id: Id70ed8bbac4bc1dc6bf66f28e65dd685f5a9d881 Reviewed-on: https://chromium-review.googlesource.com/1078067 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/25779f2c9fc7f73329dad666de9d273f386392d8/appengine/components/components/protoutil/field_masks.py [modify] https://crrev.com/25779f2c9fc7f73329dad666de9d273f386392d8/appengine/components/components/protoutil/field_masks_test.py [modify] https://crrev.com/25779f2c9fc7f73329dad666de9d273f386392d8/appengine/components/components/protoutil/test_proto.proto [modify] https://crrev.com/25779f2c9fc7f73329dad666de9d273f386392d8/appengine/components/components/protoutil/test_proto_pb2.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/427f59f773f8bd67da170ca9f567395451d04ab1 commit 427f59f773f8bd67da170ca9f567395451d04ab1 Author: Nodir Turakulov <nodir@google.com> Date: Wed May 30 20:48:46 2018 [prpc] add context.(request|response)_encoding Add Context.request_encoding and Context.response_encoding. Context.response_encoding will be used to use decide whether to interpret field names in a field mask as json names. Bug: 847687 Change-Id: I7dab95b504430bf046139d2ba04a61e753710b7a Reviewed-on: https://chromium-review.googlesource.com/1079812 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/427f59f773f8bd67da170ca9f567395451d04ab1/appengine/components/components/prpc/__init__.py [modify] https://crrev.com/427f59f773f8bd67da170ca9f567395451d04ab1/appengine/components/components/prpc/context.py [modify] https://crrev.com/427f59f773f8bd67da170ca9f567395451d04ab1/appengine/components/components/prpc/server.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/52f7af524e6b722c936502a94a255ed948854709 commit 52f7af524e6b722c936502a94a255ed948854709 Author: Nodir Turakulov <nodir@google.com> Date: Fri Jun 01 15:40:28 2018 [buildbucket] Add support for JSONPB field mask If response is JSON, parse field mask with json_names=True Bug: 847687 Change-Id: Ibe5c624e1695dfbb7fb6e9efb71f1baf04391edd Reviewed-on: https://chromium-review.googlesource.com/1079848 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/52f7af524e6b722c936502a94a255ed948854709/appengine/cr-buildbucket/v2/api.py
Comment 1 by no...@chromium.org
, May 30 2018