Unify dump_to_file methods for skylab_inventory |
||||||
Issue descriptionThe UpSync should use the dump_to_file APIs (e.g.dump_infrastructure, dump_lab) in text_manager.py, otherwise each change CL generated by "atest" tool will show big diff and most of them are ordering changes.
,
Jun 7 2018
Yeah, Charlene ported these scripts from another context, and didn't rewrite them to use the library functions... :(
,
Jun 7 2018
Can you (nxia@) treat this as a stretch CL this week? If not, I'll see who / when to hand this to. It's an unfortunate bug :/
,
Jun 7 2018
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Aug 23
Got to this as part of unrelated work: https://chromium-review.googlesource.com/c/chromiumos/infra/skylab_inventory/+/1187276
,
Aug 23
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/1fc6463e86e013fd08208d311d3963d1a53664d3 commit 1fc6463e86e013fd08208d311d3963d1a53664d3 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Aug 28 22:47:02 2018 upsync: Use text_manager to load/dump lab proto BUG= chromium:847682 TEST=unittests; Run upsync before/after CL and diff. Change-Id: I0d1f18e046494a91a10ceb1778660152ec9e7854 Reviewed-on: https://chromium-review.googlesource.com/1187276 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/1fc6463e86e013fd08208d311d3963d1a53664d3/venv/skylab_inventory/scripts/upsync.py [modify] https://crrev.com/1fc6463e86e013fd08208d311d3963d1a53664d3/venv/skylab_inventory/text_manager.py [modify] https://crrev.com/1fc6463e86e013fd08208d311d3963d1a53664d3/venv/skylab_inventory/scripts/upsync_unittest.py
,
Aug 29
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by xixuan@chromium.org
, Jun 6 2018