New issue
Advanced search Search tips

Issue 847681 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

[IndexedDB] Backing store corruption is not handled for the GetDatabaseNames call

Project Member Reported by dmu...@chromium.org, May 30 2018

Issue description

The backing store should be deleted and recreated, but instead this just sends an error to the renderer and leaves us in a corrupt state.
 
Project Member

Comment 2 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10cc9570a11e9428b1db8c9acf9108a8198f143e

commit 10cc9570a11e9428b1db8c9acf9108a8198f143e
Author: Daniel Murphy <dmurph@chromium.org>
Date: Wed May 30 02:57:43 2018

[IndexedDB] Handle corruption in GetDatabaseNames

Bug: 829141,  847681 
Change-Id: I6679e700049fb13d94322a4e8b0f87bc1310fe9e
Reviewed-on: https://chromium-review.googlesource.com/1077677
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562708}
[modify] https://crrev.com/10cc9570a11e9428b1db8c9acf9108a8198f143e/content/browser/indexed_db/indexed_db_factory_impl.cc

Comment 3 by dmu...@chromium.org, May 30 2018

Labels: Merge-Request-68
Requesting merge to 68 so that branch correctly handles corrupt databases on getDatabaseNames
Please add appropriate impacted OS. 
Project Member

Comment 5 by sheriffbot@chromium.org, May 31 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by dmu...@chromium.org, May 31 2018

Labels: OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows
Project Member

Comment 7 by bugdroid1@chromium.org, May 31 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/498cfcc952b3cb1b2975e4ffc2d60b326ff64105

commit 498cfcc952b3cb1b2975e4ffc2d60b326ff64105
Author: Daniel Murphy <dmurph@chromium.org>
Date: Thu May 31 19:48:01 2018

[IndexedDB] Handle corruption in GetDatabaseNames

Bug: 829141,  847681 
Change-Id: I6679e700049fb13d94322a4e8b0f87bc1310fe9e
Reviewed-on: https://chromium-review.googlesource.com/1077677
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562708}(cherry picked from commit 10cc9570a11e9428b1db8c9acf9108a8198f143e)
Reviewed-on: https://chromium-review.googlesource.com/1081169
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#64}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/498cfcc952b3cb1b2975e4ffc2d60b326ff64105/content/browser/indexed_db/indexed_db_factory_impl.cc

Comment 8 by dmu...@chromium.org, May 31 2018

Status: Fixed (was: Assigned)

Sign in to add a comment