New issue
Advanced search Search tips

Issue 847669 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Fuchsia: renderer process fails to start

Project Member Reported by sergeyu@chromium.org, May 29 2018

Issue description

On Fuchsia:
1. Run content_shell
2. Observe that renderer process exits quickly after being started.

This is caused by bogus ifdefs around RenderProcessImpl initialization in content/renderer/renderer_main.cc, which were written with assumption that all non-Windows platforms are POSIX.
 
Description: Show this description

Comment 2 by w...@chromium.org, May 30 2018

Labels: -Type-Bug M-69 Type-Bug-Regression
Adding target milestone, since this is P-1. :)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55195e9d7cb230094041ce5331c4831f9a65d158

commit 55195e9d7cb230094041ce5331c4831f9a65d158
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Jun 01 18:31:16 2018

Fix renderer_main.cc to work on not-POSIX platforms other than Windows.

RendererMain() was not initializing renderer on platforms that don't
declare OS_POSIX, except Windows. Also cleaned-up RendererProcessImpl
initialization to make this problem less likely in the future.

Bug:  847669 
Change-Id: I9a0ed7b39959deb980838699a3ebbec28c469265
Reviewed-on: https://chromium-review.googlesource.com/1077603
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563729}
[modify] https://crrev.com/55195e9d7cb230094041ce5331c4831f9a65d158/content/renderer/renderer_main.cc

Status: Fixed (was: Started)

Sign in to add a comment