IDN confusability checks are currently done against top 10K domains. Doing them against user's previously visited URLs could catch more spoofing attacks.
We are going to use site engagement list instead of browsing history to prevent drive-by navigations from polluting navigation suggestions. Design: https://docs.google.com/document/d/1gQCTenYuRnP77nMOo8RpS3SUxCiVewxQ9uQ3fuSefdY CL: https://chromium-review.googlesource.com/c/chromium/src/+/1162919
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5630fd7d97025c600ff0ea2c42483eb9b61adc77 commit 5630fd7d97025c600ff0ea2c42483eb9b61adc77 Author: Mustafa Emre Acer <meacer@chromium.org> Date: Fri Aug 10 17:12:00 2018 Trigger IDN navigation suggestion UI for sites in site engagement list This CL expands the navigation suggestion feature by looking for potential suggestions in the engaged sites list using the site engagement service. The match is still done by computing ICU skeletons of the hostnames. The skeletons are calculated from the eTDL+1 portions of the navigated and engaged sites, so that a navigation to a subdomain of a site looking similar to an engaged site successfully triggers the UI. Design: https://docs.google.com/document/d/1gQCTenYuRnP77nMOo8RpS3SUxCiVewxQ9uQ3fuSefdY/edit?usp=sharing Bug: 847662 Change-Id: I708b8f2503b16da8241145afe2f4aa0d2c001b9c Reviewed-on: https://chromium-review.googlesource.com/1162919 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582218} [modify] https://crrev.com/5630fd7d97025c600ff0ea2c42483eb9b61adc77/chrome/browser/ui/omnibox/idn_navigation_observer.cc [modify] https://crrev.com/5630fd7d97025c600ff0ea2c42483eb9b61adc77/chrome/browser/ui/omnibox/idn_navigation_observer.h [modify] https://crrev.com/5630fd7d97025c600ff0ea2c42483eb9b61adc77/chrome/browser/ui/omnibox/idn_navigation_observer_browsertest.cc [modify] https://crrev.com/5630fd7d97025c600ff0ea2c42483eb9b61adc77/components/url_formatter/idn_spoof_checker.cc [modify] https://crrev.com/5630fd7d97025c600ff0ea2c42483eb9b61adc77/components/url_formatter/idn_spoof_checker.h [modify] https://crrev.com/5630fd7d97025c600ff0ea2c42483eb9b61adc77/components/url_formatter/url_formatter.cc [modify] https://crrev.com/5630fd7d97025c600ff0ea2c42483eb9b61adc77/components/url_formatter/url_formatter.h [modify] https://crrev.com/5630fd7d97025c600ff0ea2c42483eb9b61adc77/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9279c680195fb6342b5ed447d387f18aaf474038 commit 9279c680195fb6342b5ed447d387f18aaf474038 Author: Mustafa Emre Acer <meacer@chromium.org> Date: Thu Aug 23 01:45:55 2018 Add a feature parameter to disable UI for IDN navigation suggestions This CL adds a "metrics_only" parameter to IdnNavigationSuggestions feature. When set to "true", the parameter will suppress the display of the "Did you mean to go to ..." UI and only record metrics. Bug: 843361,847662 Change-Id: Idb72225ff0fc2f011bd2c1ae5bb0ee7167d687ba Reviewed-on: https://chromium-review.googlesource.com/1182123 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#585360} [modify] https://crrev.com/9279c680195fb6342b5ed447d387f18aaf474038/chrome/browser/about_flags.cc [modify] https://crrev.com/9279c680195fb6342b5ed447d387f18aaf474038/chrome/browser/ui/omnibox/idn_navigation_observer.cc [modify] https://crrev.com/9279c680195fb6342b5ed447d387f18aaf474038/chrome/browser/ui/omnibox/idn_navigation_observer_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/137dc8bc3bed0cbdde708372c4f97aa3732946db commit 137dc8bc3bed0cbdde708372c4f97aa3732946db Author: Mustafa Emre Acer <meacer@chromium.org> Date: Wed Aug 29 20:38:13 2018 Rename IdnNavigationSuggestions feature to LookalikeUrlNavigationSuggestions Also rename any related classes. In the future we might show suggestions for non-IDN navigations as well, this is to prepare for that. Bug: 843361,847662 Change-Id: Id614decdc1b108923d6934c66b99274a2477e0a3 Reviewed-on: https://chromium-review.googlesource.com/1187227 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#587283} [modify] https://crrev.com/137dc8bc3bed0cbdde708372c4f97aa3732946db/chrome/browser/about_flags.cc [modify] https://crrev.com/137dc8bc3bed0cbdde708372c4f97aa3732946db/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/137dc8bc3bed0cbdde708372c4f97aa3732946db/chrome/browser/flag_descriptions.h [modify] https://crrev.com/137dc8bc3bed0cbdde708372c4f97aa3732946db/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/137dc8bc3bed0cbdde708372c4f97aa3732946db/chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc [modify] https://crrev.com/137dc8bc3bed0cbdde708372c4f97aa3732946db/chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h [rename] https://crrev.com/137dc8bc3bed0cbdde708372c4f97aa3732946db/chrome/browser/ui/omnibox/lookalike_url_navigation_observer.cc [rename] https://crrev.com/137dc8bc3bed0cbdde708372c4f97aa3732946db/chrome/browser/ui/omnibox/lookalike_url_navigation_observer.h [rename] https://crrev.com/137dc8bc3bed0cbdde708372c4f97aa3732946db/chrome/browser/ui/omnibox/lookalike_url_navigation_observer_browsertest.cc [modify] https://crrev.com/137dc8bc3bed0cbdde708372c4f97aa3732946db/chrome/browser/ui/tab_helpers.cc [modify] https://crrev.com/137dc8bc3bed0cbdde708372c4f97aa3732946db/chrome/common/chrome_features.cc [modify] https://crrev.com/137dc8bc3bed0cbdde708372c4f97aa3732946db/chrome/common/chrome_features.h [modify] https://crrev.com/137dc8bc3bed0cbdde708372c4f97aa3732946db/chrome/test/BUILD.gn [modify] https://crrev.com/137dc8bc3bed0cbdde708372c4f97aa3732946db/tools/metrics/histograms/enums.xml [modify] https://crrev.com/137dc8bc3bed0cbdde708372c4f97aa3732946db/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f6426aee3db734ba341f6f866369f75197f3fcb commit 2f6426aee3db734ba341f6f866369f75197f3fcb Author: Mustafa Emre Acer <meacer@chromium.org> Date: Thu Aug 30 21:15:13 2018 Use the correct navigation event when checking for lookalike URL suggestions The current code uses NavigationEntryCommitted, but it should have used DidNavigationFinish instead. Bug: 843361, 847662 Change-Id: Ie16016844e636a14c2114450a6e3b2a94cd2529b Reviewed-on: https://chromium-review.googlesource.com/1197083 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#587767} [modify] https://crrev.com/2f6426aee3db734ba341f6f866369f75197f3fcb/chrome/browser/ui/omnibox/lookalike_url_navigation_observer.cc [modify] https://crrev.com/2f6426aee3db734ba341f6f866369f75197f3fcb/chrome/browser/ui/omnibox/lookalike_url_navigation_observer.h [modify] https://crrev.com/2f6426aee3db734ba341f6f866369f75197f3fcb/chrome/browser/ui/omnibox/lookalike_url_navigation_observer_browsertest.cc
Comment 1 by mea...@chromium.org
, Jun 1 2018