New issue
Advanced search Search tips

Issue 847652 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 847651

Blocking:
issue 825890



Sign in to add a comment

Expose display cutout safe area as CSS environment variables

Project Member Reported by beccahughes@chromium.org, May 29 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aadcb29e98407f54aa6b4ce2b0497beeb5123194

commit aadcb29e98407f54aa6b4ce2b0497beeb5123194
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Jun 21 23:13:44 2018

[Display Cutout] Expose safe area through CSS

Add a DisplayCutoutClient mojo interface that is bound to a
frame and called from the browser. This will set safe-area*
CSS env() variables that websites can use to layout their
content based on the safe area.

DisplayCutoutClient will be called from Android in a future
CL.

BUG= 847652 

Change-Id: I6180aa5337e182fd1794586c47caef0f19fab718
Reviewed-on: https://chromium-review.googlesource.com/1083291
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569427}
[modify] https://crrev.com/aadcb29e98407f54aa6b4ce2b0497beeb5123194/content/browser/display_cutout_browsertest.cc
[modify] https://crrev.com/aadcb29e98407f54aa6b4ce2b0497beeb5123194/third_party/blink/public/mojom/page/display_cutout.mojom
[modify] https://crrev.com/aadcb29e98407f54aa6b4ce2b0497beeb5123194/third_party/blink/renderer/controller/blink_initializer.cc
[modify] https://crrev.com/aadcb29e98407f54aa6b4ce2b0497beeb5123194/third_party/blink/renderer/core/frame/BUILD.gn
[add] https://crrev.com/aadcb29e98407f54aa6b4ce2b0497beeb5123194/third_party/blink/renderer/core/frame/display_cutout_client_impl.cc
[add] https://crrev.com/aadcb29e98407f54aa6b4ce2b0497beeb5123194/third_party/blink/renderer/core/frame/display_cutout_client_impl.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3f7a87660f4917d3347a4a8b0988f3f4b3b6468

commit d3f7a87660f4917d3347a4a8b0988f3f4b3b6468
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Jun 26 02:15:31 2018

[Display Cutout] Send safe areas from Android

This sends the safe areas from Android to Blink using the
DisplayCutoutClient Mojo interface.

This CL also includes instrumentation tests for end to end
testing of Display Cutout on Android.

BUG= 847652 

Change-Id: Ide2bed7878a22d649914fde66083c28374f4d768
Reviewed-on: https://chromium-review.googlesource.com/1097802
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570293}
[modify] https://crrev.com/d3f7a87660f4917d3347a4a8b0988f3f4b3b6468/chrome/android/java/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutController.java
[modify] https://crrev.com/d3f7a87660f4917d3347a4a8b0988f3f4b3b6468/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/d3f7a87660f4917d3347a4a8b0988f3f4b3b6468/chrome/android/java_sources.gni
[add] https://crrev.com/d3f7a87660f4917d3347a4a8b0988f3f4b3b6468/chrome/android/javatests/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutTest.java
[add] https://crrev.com/d3f7a87660f4917d3347a4a8b0988f3f4b3b6468/chrome/android/javatests/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutTestRule.java
[add] https://crrev.com/d3f7a87660f4917d3347a4a8b0988f3f4b3b6468/chrome/android/javatests/src/org/chromium/chrome/browser/display_cutout/OWNERS
[modify] https://crrev.com/d3f7a87660f4917d3347a4a8b0988f3f4b3b6468/chrome/android/junit/src/org/chromium/chrome/browser/display_cutout/OWNERS
[modify] https://crrev.com/d3f7a87660f4917d3347a4a8b0988f3f4b3b6468/chrome/browser/BUILD.gn
[add] https://crrev.com/d3f7a87660f4917d3347a4a8b0988f3f4b3b6468/chrome/browser/android/display_cutout/OWNERS
[add] https://crrev.com/d3f7a87660f4917d3347a4a8b0988f3f4b3b6468/chrome/browser/android/display_cutout/display_cutout_controller_android.cc
[modify] https://crrev.com/d3f7a87660f4917d3347a4a8b0988f3f4b3b6468/chrome/browser/chrome_content_renderer_manifest_overlay.json
[add] https://crrev.com/d3f7a87660f4917d3347a4a8b0988f3f4b3b6468/chrome/test/data/android/display_cutout/shared.js
[add] https://crrev.com/d3f7a87660f4917d3347a4a8b0988f3f4b3b6468/chrome/test/data/android/display_cutout/subframe.html
[add] https://crrev.com/d3f7a87660f4917d3347a4a8b0988f3f4b3b6468/chrome/test/data/android/display_cutout/test_page.html

Status: Fixed (was: Assigned)

Sign in to add a comment