New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847647 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

[Standalone] Clicking 'details" from security lock indicator displays incorrect background UI in content area

Project Member Reported by dbbrooks@chromium.org, May 29 2018

Issue description

Chrome Version: 68.0.3440.7
Build: OVRB.180423.027  / Lenovo VR 
Daydream: 1.15.180423024
VRCore: 1.15.196923100

What steps will reproduce the problem?
(1) Go to wikipedia.org and click lock icon in url bar.
(2) Click "details" link on the dialog that appears.


What is the expected result? See screenshot, the black content area should not be displayed.

What happens instead? See screenshot. There's a black content area that looks like a webvr presentation with a portion of an x and settings icon at the top and a short verticle center line at the bottom.

 
details.jpg
51.1 KB View Download
Labels: Pri-2 Type-Bug
Owner: mthiesse@chromium.org
Status: Available (was: Untriaged)
Cc: santoscordon@google.com
I'll see if we can do any better, but we probably can't. This is a platform bug and the gvr folks are looking into it.

cc santos (though note this is a public currently)
Is this better? 
Screenshot_20180531_183612.jpg
48.2 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94d2fced205e76938245203132e0fe6119f077f3

commit 94d2fced205e76938245203132e0fe6119f077f3
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Fri Jun 01 18:53:09 2018

VR: Avoid showing the gvrlayout when a popup is visible on standalones.

There's currently a platform bug where the 2D app behind the popup is
rendered on standalones when it shouldn't be, and as we're in VR it
shows the gvrLayout, including 'x' and gear icons. We get a slightly
less bad experience by hiding the gvrlayout. See the screenshots in the
bug.

Bug:  847647 
Change-Id: Ib1eed670b116e6c17e72c742c356b2d188194c10
Reviewed-on: https://chromium-review.googlesource.com/1082004
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563740}
[modify] https://crrev.com/94d2fced205e76938245203132e0fe6119f077f3/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Status: ExternalDependency (was: Available)
Alright I've done my best, remaining issues have to be solved at the platform level.

Santos, you mentioned you were looking into this issue? Had an internal bug been filed we could link to here?
Labels: Merge-Request-68
Looks good on Canary.
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 11 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by cmasso@google.com, Jun 12 2018

Labels: -Hotlist-Merge-Review -Merge-Review-68 Merge-Approved-68
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 12 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b97240627f05c7d12c6d6bc29a5cff56194e0368

commit b97240627f05c7d12c6d6bc29a5cff56194e0368
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Tue Jun 12 19:05:48 2018

VR: Avoid showing the gvrlayout when a popup is visible on standalones.

There's currently a platform bug where the 2D app behind the popup is
rendered on standalones when it shouldn't be, and as we're in VR it
shows the gvrLayout, including 'x' and gear icons. We get a slightly
less bad experience by hiding the gvrlayout. See the screenshots in the
bug.

TBR=mthiesse@chromium.org

(cherry picked from commit 94d2fced205e76938245203132e0fe6119f077f3)

Bug:  847647 
Change-Id: Ib1eed670b116e6c17e72c742c356b2d188194c10
Reviewed-on: https://chromium-review.googlesource.com/1082004
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563740}
Reviewed-on: https://chromium-review.googlesource.com/1097706
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#307}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/b97240627f05c7d12c6d6bc29a5cff56194e0368/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Labels: -M-68
Removing milestone to track DD fixes.
Owner: ----
Status: Fixed (was: ExternalDependency)
This looks fixed to me when I tried to repro. Let me know if I'm missing something.

Sign in to add a comment