Issue metadata
Sign in to add a comment
|
Unit test are failing for M-68 (10718.4.0 68.0.3440.4) |
||||||||||||||||||||
Issue descriptionHere are some sample failures, failed cbuildbot_launch [samus-release] failed UnitTest failed ImageTest failed Report failed cbuildbot_launch [auron_paine-release] failed UnitTest failed ImageTest failed Report The devices affected can be check at https://cros-goldeneye.corp.google.com/chromeos/console/listBuild#/details Can we also check this, apart from failing bvt-cq test if it is affecting users and will be blocking M68 today?
,
May 29 2018
As suggested, marking this as dev-blocker.
,
May 29 2018
I am hoping this is resolved in the next build along with the fix for https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1075987 AFAIK this does not have any user facing impact.
,
May 30 2018
Ok. I also checked manually installing image on Samus and didn't see any issue.
,
May 30 2018
,
May 30 2018
cros-disks-0.0.1-r2526: ../../../../../../../tmp/portage/chromeos-base/cros-disks-0.0.1-r2526/work/cros-disks-0.0.1/cros-disks/udev_device_unittest.cc:244: Failure cros-disks-0.0.1-r2526: Expected: 0 cros-disks-0.0.1-r2526: To be equal to: device.GetPartitionCount() cros-disks-0.0.1-r2526: Which is: 12 cros-disks-0.0.1-r2526: terminating with uncaught exception of type testing::internal::GoogleTestFailureException: ../../../../../../../tmp/portage/chromeos-base/cros-disks-0.0.1-r2526/work/cros-disks-0.0.1/cros-disks/udev_device_unittest.cc:244: Failure cros-disks-0.0.1-r2526: Expected: 0 cros-disks-0.0.1-r2526: To be equal to: device.GetPartitionCount() cros-disks-0.0.1-r2526: Which is: 12 cros-disks-0.0.1-r2526: Error: /var/cache/portage/chromeos-base/cros-disks/out/Default/disks_testrunner: failed with signal SIGIOT|SIGABRT(6)
,
May 30 2018
Asuka first starts failing at https://crosland.corp.google.com/log/10710.0.0..10714.0.0 Given this is complaining about udev, I am guessing this is some 3.18 kernel pick within https://bugs.chromium.org/p/chromium/issues/detail?id=842936 , though not all 3.18 devices started failing. Asuka starts passing again at https://crosland.corp.google.com/log/10723.0.0..10724.0.0 However this has no notable changes in it. So maybe this is some flake that just happens a lot on the 68 branch...
,
May 30 2018
Ben, can you help narrow this down further, you seem to have the most commits to this test?
,
May 30 2018
,
May 30 2018
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/9e00f57c56dec385c97f7bc9bb4b19e804f3954b commit 9e00f57c56dec385c97f7bc9bb4b19e804f3954b Author: Ben Chan <benchan@chromium.org> Date: Wed May 30 17:49:52 2018 cros-disks: remove a GetPartitionCount test case with incorrect assumption This CL removes a test case in UdevDeviceTest.GetPartitionCount, which incorrectly assumes that a loop device has no partition. However, a loop device with an attached disk image may contain a partition. BUG= chromium:847645 TEST=Run unit tests. Change-Id: I5aacac3f50bf9ad9f233c7143b5d32877b53f2ed Reviewed-on: https://chromium-review.googlesource.com/1079507 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Commit-Queue: Bernie Thompson <bhthompson@chromium.org> Tested-by: Bernie Thompson <bhthompson@chromium.org> [modify] https://crrev.com/9e00f57c56dec385c97f7bc9bb4b19e804f3954b/cros-disks/udev_device_unittest.cc
,
May 30 2018
As this failure is not user facing, and appears to be a byproduct of what the builder itself is doing, we don't need to block dev on this.
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/0bfdcd5675ee83f8b929226730d7f1c35bcd9bdb commit 0bfdcd5675ee83f8b929226730d7f1c35bcd9bdb Author: Ben Chan <benchan@chromium.org> Date: Thu May 31 10:50:23 2018 cros-disks: remove a GetPartitionCount test case with incorrect assumption This CL removes a test case in UdevDeviceTest.GetPartitionCount, which incorrectly assumes that a loop device has no partition. However, a loop device with an attached disk image may contain a partition. BUG= chromium:847645 TEST=Run unit tests. Change-Id: I5aacac3f50bf9ad9f233c7143b5d32877b53f2ed Reviewed-on: https://chromium-review.googlesource.com/1079455 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> [modify] https://crrev.com/0bfdcd5675ee83f8b929226730d7f1c35bcd9bdb/cros-disks/udev_device_unittest.cc
,
May 31 2018
,
Jun 4 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 8 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f5c23782d1df07e5f168d976121a04da36bbdede commit f5c23782d1df07e5f168d976121a04da36bbdede Author: Ben Chan <benchan@chromium.org> Date: Thu Jul 26 09:12:01 2018 cros-disks: remove a GetPartitionCount test case with incorrect assumption This CL removes a test case in UdevDeviceTest.GetPartitionCount, which incorrectly assumes that a loop device has no partition. However, a loop device with an attached disk image may contain a partition. BUG= chromium:847645 TEST=Run unit tests. Change-Id: I5aacac3f50bf9ad9f233c7143b5d32877b53f2ed Reviewed-on: https://chromium-review.googlesource.com/1079455 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> (cherry picked from commit 0bfdcd5675ee83f8b929226730d7f1c35bcd9bdb) Reviewed-on: https://chromium-review.googlesource.com/1151128 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Commit-Queue: Zhuohao Lee <zhuohao@chromium.org> Tested-by: Zhuohao Lee <zhuohao@chromium.org> [modify] https://crrev.com/f5c23782d1df07e5f168d976121a04da36bbdede/cros-disks/udev_device_unittest.cc
,
Today
(17 hours ago)
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by dchan@google.com
, May 29 2018