New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 847641 link

Starred by 1 user
Status: Fixed
Owner:
lijeffrey@chromium.org
Closed: Jun 2018
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Errors in subpipelines may not be surfaced

Project Member Reported by lijeffrey@chromium.org, May 29 2018 
https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKNAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtZGJnLzU4ODUvY29udGVudF9icm93c2VydGVzdHMvUVd4c0wwbHVjSFYwUkhKcGRtVnVTR2x6ZEc5bmNtRnRRbkp2ZDNObGNsUmxjM1F1VTJOeWIyeHNVR0ZuWlZkcGRHaFViM1ZqYUM4dwwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

In this analysis, the status is completed yet there was an error in checking for flakiness in a recent build.

analyze_flake_pipeline updates the analysis' completion status and time too early: there are still more pipelines for logging bugs, notifying the culprit, etc, that can all break
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8aa478dfacd0edcaa64f52eab593f6d31be43189

commit 8aa478dfacd0edcaa64f52eab593f6d31be43189
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon Jun 04 18:43:19 2018

[Findit] Flake Analyzer - Set analysis completion status at correct time

Analysis status is being set even when there are more subpipelines. When
one of those subpipelines fails, the logic to check for updating the
status will bail out if the status is set to COMPLETED thus the errors
are not obvious.

This change is to set the analysis status only after all subpipelines
have completed.

Bug:  847641 
Change-Id: I5900d1850bf1618283ca01d2a449e4e4cd1d0b84
Reviewed-on: https://chromium-review.googlesource.com/1077606
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/8aa478dfacd0edcaa64f52eab593f6d31be43189/appengine/findit/services/flake_failure/flake_analysis_util.py
[modify] https://crrev.com/8aa478dfacd0edcaa64f52eab593f6d31be43189/appengine/findit/services/flake_failure/test/flake_analysis_util_test.py
[modify] https://crrev.com/8aa478dfacd0edcaa64f52eab593f6d31be43189/appengine/findit/pipelines/flake_failure/analyze_flake_pipeline.py
[modify] https://crrev.com/8aa478dfacd0edcaa64f52eab593f6d31be43189/appengine/findit/pipelines/flake_failure/test/analyze_flake_pipeline_test.py
[modify] https://crrev.com/8aa478dfacd0edcaa64f52eab593f6d31be43189/appengine/findit/gae_libs/pipelines.py
[modify] https://crrev.com/8aa478dfacd0edcaa64f52eab593f6d31be43189/appengine/findit/services/issue_tracking_service.py

Comment 2 by lijeffrey@chromium.org, Jun 12 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment