New issue
Advanced search Search tips

Issue 847639 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 27
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task



Sign in to add a comment

Transition search icon in bottom toolbar to new tab when in tab switcher

Project Member Reported by mdjones@chromium.org, May 29 2018

Issue description

We should exchange the search icon in the bottom toolbar to be the new tab icon while in the tab switcher.

Whether we have a separate view for the bottom tab switcher toolbar is up for discussion. Memex is adding some different buttons to the top toolbar which will likely impact the bottom toolbar as well (https://chromium-review.googlesource.com/c/chromium/src/+/1060560). If we need to support this, it probably makes sense to keep two separate toolbars.
 
Labels: -Pri-3 Pri-1
Owner: amaralp@chromium.org
Status: Started (was: Available)
Instead of having the search accelerator become the tab switcher we might want to have the home button become the tab switcher. The search accelerator could become an incognito mode button.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb2e05792b3ea69aa912dd28964c97be0d02d6bf

commit cb2e05792b3ea69aa912dd28964c97be0d02d6bf
Author: Pedro Amaral <amaralp@chromium.org>
Date: Fri Jul 27 21:07:27 2018

Moving incognito toggle button down to bottom toolbar

Moved the incognito toggle button to the bottom toolbar and removed
the new tab button and incognito toggle button from the top toolbar.

Bug:  847639 

Change-Id: I1a8c081251f2058f74ec7ad9b76865758fe136e4
Reviewed-on: https://chromium-review.googlesource.com/1152541
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578791}
[modify] https://crrev.com/cb2e05792b3ea69aa912dd28964c97be0d02d6bf/chrome/android/java/res/layout/bottom_toolbar.xml
[modify] https://crrev.com/cb2e05792b3ea69aa912dd28964c97be0d02d6bf/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarCoordinator.java
[modify] https://crrev.com/cb2e05792b3ea69aa912dd28964c97be0d02d6bf/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java
[modify] https://crrev.com/cb2e05792b3ea69aa912dd28964c97be0d02d6bf/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonSlotData.java
[modify] https://crrev.com/cb2e05792b3ea69aa912dd28964c97be0d02d6bf/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/cb2e05792b3ea69aa912dd28964c97be0d02d6bf/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

Status: Fixed (was: Started)

Sign in to add a comment