New issue
Advanced search Search tips

Issue 847634 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task



Sign in to add a comment

Reduce the height of the bottom toolbar

Project Member Reported by mdjones@chromium.org, May 29 2018

Issue description

Right now it seems like the height of the bottom toolbar matches the top toolbar. Since we don't need to support the omnibox, lets reduce the height to 48dp (right now it looks to be 56dp) to save some screen real-estate. (48dp is the minimum touch target size for accessibility)
 
Labels: -Pri-3 Pri-1
Cc: -amaralp@chromium.org
Owner: amaralp@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52a0684ab290a004e58ac0418fdac3bf2dc8daa2

commit 52a0684ab290a004e58ac0418fdac3bf2dc8daa2
Author: Pedro Amaral <amaralp@chromium.org>
Date: Sat Jun 09 00:19:40 2018

Make the bottom toolbar height smaller

Make the bottom toolbar as small as possible (so set to the miniumum
touch target size).

Bug:  847634 
Change-Id: Ibb6bb5e26af24782f6d343a186ab216589e5a0cb
Reviewed-on: https://chromium-review.googlesource.com/1090112
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565791}
[modify] https://crrev.com/52a0684ab290a004e58ac0418fdac3bf2dc8daa2/chrome/android/java/res/layout/bottom_toolbar.xml
[modify] https://crrev.com/52a0684ab290a004e58ac0418fdac3bf2dc8daa2/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/52a0684ab290a004e58ac0418fdac3bf2dc8daa2/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java

Status: Fixed (was: Assigned)

Sign in to add a comment