New issue
Advanced search Search tips

Issue 847632 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task



Sign in to add a comment

Update overflow menu for bottom toolbar

Project Member Reported by mdjones@chromium.org, May 29 2018

Issue description

Currently, the overflow menu animates from the top when opened from the bottom and the icon row is out of reach. We should animate from the bottom of the screen and move the icon row to the bottom (similar to what we did for Chrome Home).
 
Labels: -Pri-3 Pri-2
Owner: mdjones@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a53131c8cffeea3f40b38ed147990e69d03d66bc

commit a53131c8cffeea3f40b38ed147990e69d03d66bc
Author: Matthew Jones <mdjones@chromium.org>
Date: Wed Jul 11 17:54:29 2018

Overflow menu appears from the bottom when Duet is enabled

This patch adds a boolean flag to functions that trigger the overflow
menu which specifies whether the menu should appear from the bottom of
the screen.

Bug:  847632 
Change-Id: Ifadfb787e66176995811876187c4f955e21bd66e
Reviewed-on: https://chromium-review.googlesource.com/1132248
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574238}
[modify] https://crrev.com/a53131c8cffeea3f40b38ed147990e69d03d66bc/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/a53131c8cffeea3f40b38ed147990e69d03d66bc/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
[modify] https://crrev.com/a53131c8cffeea3f40b38ed147990e69d03d66bc/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java
[modify] https://crrev.com/a53131c8cffeea3f40b38ed147990e69d03d66bc/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java
[modify] https://crrev.com/a53131c8cffeea3f40b38ed147990e69d03d66bc/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/a53131c8cffeea3f40b38ed147990e69d03d66bc/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java
[modify] https://crrev.com/a53131c8cffeea3f40b38ed147990e69d03d66bc/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java
[modify] https://crrev.com/a53131c8cffeea3f40b38ed147990e69d03d66bc/chrome/android/javatests/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelperTest.java

Description: Show this description
Summary: Update overflow menu for bottom toolbar (was: Fix positioning of overflow menu for bottom toolbar)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c39a9afef01acc363652cb18eb5cdcf5952c4064

commit c39a9afef01acc363652cb18eb5cdcf5952c4064
Author: Matthew Jones <mdjones@chromium.org>
Date: Mon Jul 16 23:16:27 2018

Add ability to show overflow menu icon row at bottom of menu

This patch revives some overflow menu code from ye-olde days of Chrome
Home with a sprinkle of new-age technology
(see https://codereview.chromium.org/2821223004 for the original
patch). More specifically, AppMenuIconRowFooter, icon_row_menu_footer,
and app_menu_button_tint have been revived almost exactly as they
were.

Now, when Duet is enabled the icon row is placed at the bottom of the
overflow menu to make it easier to reach with one hand.

The major difference between this and Chrome Home's version is how the
bottom icon row is initialized. This patch adds
AppMenuPropertiesDelegate#onFooterViewInflated() which gives delegates
the opportunity to make changes to the view immediately
post-inflation.

This patch breaks the data-saver menu promo while Duet is enabled,
this will be fixed in a follow-up patch which places it at the top
of the menu.

Bug:  847632 
Change-Id: Iac44bdc2880c118b97102ef074134a6f13b50da0
Reviewed-on: https://chromium-review.googlesource.com/1135892
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575472}
[add] https://crrev.com/c39a9afef01acc363652cb18eb5cdcf5952c4064/chrome/android/java/res/layout/icon_row_menu_footer.xml
[modify] https://crrev.com/c39a9afef01acc363652cb18eb5cdcf5952c4064/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/c39a9afef01acc363652cb18eb5cdcf5952c4064/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
[modify] https://crrev.com/c39a9afef01acc363652cb18eb5cdcf5952c4064/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java
[add] https://crrev.com/c39a9afef01acc363652cb18eb5cdcf5952c4064/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuIconRowFooter.java
[modify] https://crrev.com/c39a9afef01acc363652cb18eb5cdcf5952c4064/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/c39a9afef01acc363652cb18eb5cdcf5952c4064/chrome/android/java_sources.gni

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5276984635dd1a4739d040caeedb3b748b7b649

commit b5276984635dd1a4739d040caeedb3b748b7b649
Author: Matthew Jones <mdjones@chromium.org>
Date: Tue Jul 17 16:05:34 2018

Add data saver promo to top of menu in Chrome Duet

This patch adds the data saver promo to the top of the overflow menu
when Chrome Duet is enabled. The top divider for the promo has been
removed and promo now scrolls off when the menu is scrolled (only in
Duet).

Supporting this patch is a change in how the header view is provided
to the menu. Instead of passing the view directly, its layout ID is
passed instead, bringing it more in line with the footer version.
To get access to the inflated view, this patch also added
AppMenuPropertiesDelegate#onHeaderViewInflated.

Bug:  847632 
Change-Id: I1c332199f6760d1ba1f30262e122bf30ab4c835e
Reviewed-on: https://chromium-review.googlesource.com/1136714
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575658}
[modify] https://crrev.com/b5276984635dd1a4739d040caeedb3b748b7b649/chrome/android/java/res/layout/data_reduction_main_menu_item.xml
[modify] https://crrev.com/b5276984635dd1a4739d040caeedb3b748b7b649/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/b5276984635dd1a4739d040caeedb3b748b7b649/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
[modify] https://crrev.com/b5276984635dd1a4739d040caeedb3b748b7b649/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java
[modify] https://crrev.com/b5276984635dd1a4739d040caeedb3b748b7b649/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Status: Fixed (was: Started)

Sign in to add a comment