New issue
Advanced search Search tips

Issue 847620 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task

Blocked on:
issue 828636


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Support toolbar swipe functionality on Bottom Toolbar

Project Member Reported by mdjones@chromium.org, May 29 2018

Issue description

The bottom toolbar should support toolbar swipe behavior similar to how the top toolbar behaves. Ideally we can have the bottom toolbar animate in the same way as well.
 
Labels: -Type-Bug Type-Task
Blockedon: 828636
Labels: -Pri-3 Pri-2
Owner: mdjones@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6488f02a8cf67761d6c890448994be988ea4d795

commit 6488f02a8cf67761d6c890448994be988ea4d795
Author: Matthew Jones <mdjones@chromium.org>
Date: Wed Jun 20 23:31:16 2018

Add toolbar swipe behavior to bottom toolbar

This patch adds the ability to swipe the bottom toolbar to switch
between the next and previous tab (like the top toolbar). A new
property to the bottom toolbar model that allows for a swipe
handler to be set on the view. In the case of the bottom toolbar,
the same handler that is applied to the top toolbar is used.
Currently the bottom toolbar also supports "swipe down to enter
the tab switcher", this will be handled in a follow-up patch.

Bug:  847620 
Change-Id: Ifc74b500fc70a81cd58ab0ba8998a31c113fd04e
Reviewed-on: https://chromium-review.googlesource.com/1100080
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569085}
[modify] https://crrev.com/6488f02a8cf67761d6c890448994be988ea4d795/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/6488f02a8cf67761d6c890448994be988ea4d795/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
[modify] https://crrev.com/6488f02a8cf67761d6c890448994be988ea4d795/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java
[modify] https://crrev.com/6488f02a8cf67761d6c890448994be988ea4d795/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarCoordinator.java
[modify] https://crrev.com/6488f02a8cf67761d6c890448994be988ea4d795/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java
[modify] https://crrev.com/6488f02a8cf67761d6c890448994be988ea4d795/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarModel.java
[modify] https://crrev.com/6488f02a8cf67761d6c890448994be988ea4d795/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java
[modify] https://crrev.com/6488f02a8cf67761d6c890448994be988ea4d795/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ScrollingBottomViewResourceFrameLayout.java
[modify] https://crrev.com/6488f02a8cf67761d6c890448994be988ea4d795/chrome/android/javatests/src/org/chromium/chrome/browser/ContentViewFocusTest.java
[modify] https://crrev.com/6488f02a8cf67761d6c890448994be988ea4d795/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
[modify] https://crrev.com/6488f02a8cf67761d6c890448994be988ea4d795/chrome/android/javatests/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerTest.java

Status: Fixed (was: Started)

Sign in to add a comment