Implement LPD for eSIM support on Chrome OS
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/2b7bf82e4951cf837a71806092882ab7c1dfc5b5 commit 2b7bf82e4951cf837a71806092882ab7c1dfc5b5 Author: Jacob Rutherford <jruthe@chromium.org> Date: Fri Jun 08 06:33:41 2018 hermes: initial commit Hermes is the codename for the project of implementing eSIM support for Chrome OS. Hermes will be responsible for delivering messages between devices with eSIM chips and carrier servers through profile downloads as well as service discovery for new carriers. BUG=b:80591752 BUG=chromium:847619 TEST=Compiles (emerge-coral hermes) Change-Id: I994883e8db1afcb77c0d43e83abb0b5564dd25c5 Reviewed-on: https://chromium-review.googlesource.com/1073626 Commit-Ready: Jacob Rutherford <jruthe@google.com> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [add] https://crrev.com/2b7bf82e4951cf837a71806092882ab7c1dfc5b5/hermes/esim.h [add] https://crrev.com/2b7bf82e4951cf837a71806092882ab7c1dfc5b5/hermes/lpd.h [add] https://crrev.com/2b7bf82e4951cf837a71806092882ab7c1dfc5b5/hermes/esim_uim_impl.h [add] https://crrev.com/2b7bf82e4951cf837a71806092882ab7c1dfc5b5/hermes/README.md [add] https://crrev.com/2b7bf82e4951cf837a71806092882ab7c1dfc5b5/hermes/lpd.cc [add] https://crrev.com/2b7bf82e4951cf837a71806092882ab7c1dfc5b5/hermes/OWNERS [add] https://crrev.com/2b7bf82e4951cf837a71806092882ab7c1dfc5b5/hermes/esim_uim_impl.cc [add] https://crrev.com/2b7bf82e4951cf837a71806092882ab7c1dfc5b5/hermes/main.cc [add] https://crrev.com/2b7bf82e4951cf837a71806092882ab7c1dfc5b5/hermes/smdp.h [add] https://crrev.com/2b7bf82e4951cf837a71806092882ab7c1dfc5b5/hermes/smdp_fi_impl.h [add] https://crrev.com/2b7bf82e4951cf837a71806092882ab7c1dfc5b5/hermes/hermes.gyp [add] https://crrev.com/2b7bf82e4951cf837a71806092882ab7c1dfc5b5/hermes/smdp_fi_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/7f442f869ac7d649ffa3da131aec4d2666deab6a commit 7f442f869ac7d649ffa3da131aec4d2666deab6a Author: Jacob Rutherford <jruthe@chromium.org> Date: Sat Jun 16 07:44:02 2018 hermes: Rename EsimUimImpl to EsimQmiImpl sed '{ s/EsimUimImpl/EsimQmiImpl/g }' -i * sed '{ s/esim_uim/esim_qmi/g }' -i * sed '{ s/ESIM_UIM/ESIM_QMI/g }' -i * BUG=b:80591752 BUG=chromium:847619 TEST=FEATURES=test emerge-coral hermes Change-Id: I48e73c31243de60ff2642346184875b40f6e8268 Reviewed-on: https://chromium-review.googlesource.com/1096405 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> [rename] https://crrev.com/7f442f869ac7d649ffa3da131aec4d2666deab6a/hermes/esim_qmi_impl.cc [rename] https://crrev.com/7f442f869ac7d649ffa3da131aec4d2666deab6a/hermes/esim_qmi_impl.h [modify] https://crrev.com/7f442f869ac7d649ffa3da131aec4d2666deab6a/hermes/main.cc [add] https://crrev.com/7f442f869ac7d649ffa3da131aec4d2666deab6a/hermes/esim_qmi_unittest.cc [modify] https://crrev.com/7f442f869ac7d649ffa3da131aec4d2666deab6a/hermes/hermes.gyp [delete] https://crrev.com/faa5067a2d3e324ebcff686e7b4a42a65a1c8abb/hermes/esim_uim_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/fe2a4042825a96c482b2dff19cfcf03f037c1095 commit fe2a4042825a96c482b2dff19cfcf03f037c1095 Author: Jacob Rutherford <jruthe@chromium.org> Date: Thu Jun 28 05:07:16 2018 hermes: Prepare QMI and MessageLoop support Add functionality to Esim::SendEsimMessage to send messages to Esim through posting a Task to the thread's MessageLoop. BUG=b:80591752 BUG=chromium:847619 TEST=emerge-cheza hermes Change-Id: Ia7aa5e59636d5f2578d2521eba6062b9db95efaf Reviewed-on: https://chromium-review.googlesource.com/1100394 Commit-Ready: Jacob Rutherford <jruthe@google.com> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [modify] https://crrev.com/fe2a4042825a96c482b2dff19cfcf03f037c1095/hermes/esim.h [add] https://crrev.com/fe2a4042825a96c482b2dff19cfcf03f037c1095/hermes/qmi_constants.h [modify] https://crrev.com/fe2a4042825a96c482b2dff19cfcf03f037c1095/hermes/esim_qmi_impl.cc [modify] https://crrev.com/fe2a4042825a96c482b2dff19cfcf03f037c1095/hermes/esim_qmi_impl.h [modify] https://crrev.com/fe2a4042825a96c482b2dff19cfcf03f037c1095/hermes/smdp_fi_unittest.cc [modify] https://crrev.com/fe2a4042825a96c482b2dff19cfcf03f037c1095/hermes/main.cc [modify] https://crrev.com/fe2a4042825a96c482b2dff19cfcf03f037c1095/hermes/esim_qmi_unittest.cc [modify] https://crrev.com/fe2a4042825a96c482b2dff19cfcf03f037c1095/hermes/lpd.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/77c64a5a8e4dfba60544df946dbfec238d0e80b2 commit 77c64a5a8e4dfba60544df946dbfec238d0e80b2 Author: Jacob Rutherford <jruthe@chromium.org> Date: Sat Jul 07 01:48:35 2018 hermes: Generic Esim error handling QMI will return a specific set of error codes, which must be translated to more generic Esim errors and then even more generic LPA errors. BUG=b:80591752 BUG=chromium:847619 TEST=emerge-cheza hermes CQ-DEPEND=CL:1100475 Change-Id: I9b20b99a7183d06036da0e37c56e93c15c7fa5f5 Reviewed-on: https://chromium-review.googlesource.com/1100475 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/77c64a5a8e4dfba60544df946dbfec238d0e80b2/hermes/esim.h [modify] https://crrev.com/77c64a5a8e4dfba60544df946dbfec238d0e80b2/hermes/lpd.h [modify] https://crrev.com/77c64a5a8e4dfba60544df946dbfec238d0e80b2/hermes/qmi_constants.h [modify] https://crrev.com/77c64a5a8e4dfba60544df946dbfec238d0e80b2/hermes/esim_qmi_impl.cc [modify] https://crrev.com/77c64a5a8e4dfba60544df946dbfec238d0e80b2/hermes/esim_qmi_impl.h [modify] https://crrev.com/77c64a5a8e4dfba60544df946dbfec238d0e80b2/hermes/main.cc [modify] https://crrev.com/77c64a5a8e4dfba60544df946dbfec238d0e80b2/hermes/esim_qmi_unittest.cc [modify] https://crrev.com/77c64a5a8e4dfba60544df946dbfec238d0e80b2/hermes/lpd.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/68f896f36f2b75a2c35de2f958391da73c664347 commit 68f896f36f2b75a2c35de2f958391da73c664347 Author: Jacob Rutherford <jruthe@chromium.org> Date: Tue Jul 10 00:59:22 2018 hermes: Rename std::vector<uint8_t> to DataBlob The data exchange between the eSIM and the SM-DP+ server is encrypted by either end using keys that are unknown to the Lpd. DataBlob conveys that the Lpd API shouldn't care about what data is being transferred between the two endpoints except for the header of the packets. BUG=b:80591752 BUG=chromium:847619 TEST=emerge-cheza hermes Change-Id: I4f123175fe8929087ce4de38996662ea646433a0 Reviewed-on: https://chromium-review.googlesource.com/1119502 Commit-Ready: Jacob Rutherford <jruthe@google.com> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/68f896f36f2b75a2c35de2f958391da73c664347/hermes/esim.h [modify] https://crrev.com/68f896f36f2b75a2c35de2f958391da73c664347/hermes/esim_qmi_impl.cc [modify] https://crrev.com/68f896f36f2b75a2c35de2f958391da73c664347/hermes/esim_qmi_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/1b7173b0ba7805558cac05e54964c7c787c348dd commit 1b7173b0ba7805558cac05e54964c7c787c348dd Author: Jacob Rutherford <jruthe@chromium.org> Date: Tue Jul 10 00:59:22 2018 hermes: Add base::ScopedFD for QRTR socket The QRTR socket will be held in a ScopedFD that will be invalid once the EsimQmiImpl object is out of scope. BUG=b:80591752 BUG=chromium:847619 TEST=FEATURES=test emerge-cheza hermes Change-Id: I73db3b32909b6c89d48486786fb313ddc5f1eebd Reviewed-on: https://chromium-review.googlesource.com/1119503 Commit-Ready: Jacob Rutherford <jruthe@google.com> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/1b7173b0ba7805558cac05e54964c7c787c348dd/hermes/esim_qmi_impl.cc [modify] https://crrev.com/1b7173b0ba7805558cac05e54964c7c787c348dd/hermes/esim_qmi_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/56c844c7c819a20479e91f57613ce13c71c522cf commit 56c844c7c819a20479e91f57613ce13c71c522cf Author: Jacob Rutherford <jruthe@chromium.org> Date: Tue Jul 10 05:35:41 2018 hermes: Add libqrtr basics Link against libqrtr, add qrtr_open and qrtr_new_lookup. BUG=b:80591752 BUG=chromium:847619 TEST=FEATURES=test emerge-cheza hermes Change-Id: If1613edd81b816733197593040d4ab257033f1ca Reviewed-on: https://chromium-review.googlesource.com/1119528 Commit-Ready: Jacob Rutherford <jruthe@google.com> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/56c844c7c819a20479e91f57613ce13c71c522cf/hermes/esim.h [modify] https://crrev.com/56c844c7c819a20479e91f57613ce13c71c522cf/hermes/qmi_constants.h [modify] https://crrev.com/56c844c7c819a20479e91f57613ce13c71c522cf/hermes/esim_qmi_impl.cc [modify] https://crrev.com/56c844c7c819a20479e91f57613ce13c71c522cf/hermes/esim_qmi_impl.h [modify] https://crrev.com/56c844c7c819a20479e91f57613ce13c71c522cf/hermes/esim_qmi_unittest.cc [modify] https://crrev.com/56c844c7c819a20479e91f57613ce13c71c522cf/hermes/hermes.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/026b4fbe99dd54042bd67a80e74833eeac46d766 commit 026b4fbe99dd54042bd67a80e74833eeac46d766 Author: Jacob Rutherford <jruthe@chromium.org> Date: Tue Jul 10 05:35:41 2018 hermes: Add factory methods and Initialize method Add Create() method for instantiation of EsimQmiImpl, and CreateForTest() for EsimQmiImplTest. Initialize creates a connection over a QRTR socket (or a mock for unit testing). BUG=b:80591752 BUG=chromium:847619 TEST=FEATURES=test emerge-cheza hermes CQ-DEPEND=CL:1119528 Change-Id: I25536f78cb5bdd635730a8c7eb2f5dcc27db80e2 Reviewed-on: https://chromium-review.googlesource.com/1119529 Commit-Ready: Jacob Rutherford <jruthe@google.com> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/026b4fbe99dd54042bd67a80e74833eeac46d766/hermes/esim.h [modify] https://crrev.com/026b4fbe99dd54042bd67a80e74833eeac46d766/hermes/esim_qmi_unittest.cc [modify] https://crrev.com/026b4fbe99dd54042bd67a80e74833eeac46d766/hermes/main.cc [modify] https://crrev.com/026b4fbe99dd54042bd67a80e74833eeac46d766/hermes/esim_qmi_impl.cc [modify] https://crrev.com/026b4fbe99dd54042bd67a80e74833eeac46d766/hermes/esim_qmi_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/399c3666aab9e6c1cdd4622260ae05315185441a commit 399c3666aab9e6c1cdd4622260ae05315185441a Author: Jacob Rutherford <jruthe@chromium.org> Date: Mon Jul 23 19:59:46 2018 hermes: Add qmic generated files Add generated files using the qmic tool, found here: https://github.com/andersson/qmic. Using the configuration specified in qmi_uim.qmi, qmic generates qmi_uim.h and qmi_uim.c which specify how to encode and decode QMI packets to pass to the eSIM chip. Slight modifications were made to qmi_uim.c, since the length field of send_apdu packets are 2 bytes rather than 1. So they've been changed from the default uint8_t to uint16_t. Other than that, the defaults should be sufficient to regenerate these files. BUG=b:80591752 BUG=chromium:847619 TEST=None CQ-DEPEND=CL:1119529 Change-Id: I167c09cee92f6ad874bece4669b1af3a06f01e9a Reviewed-on: https://chromium-review.googlesource.com/1134581 Commit-Ready: Jacob Rutherford <jruthe@google.com> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> [add] https://crrev.com/399c3666aab9e6c1cdd4622260ae05315185441a/hermes/qmi_uim.h [modify] https://crrev.com/399c3666aab9e6c1cdd4622260ae05315185441a/hermes/hermes.gyp [add] https://crrev.com/399c3666aab9e6c1cdd4622260ae05315185441a/hermes/qmi_uim.qmi [add] https://crrev.com/399c3666aab9e6c1cdd4622260ae05315185441a/hermes/qmi_uim.c
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/35147441fb68e5a8b9d41c853280f24554f1a3ca commit 35147441fb68e5a8b9d41c853280f24554f1a3ca Author: Jacob Rutherford <jruthe@chromium.org> Date: Mon Jul 23 19:59:47 2018 hermes: Add MessageLoopForIO::FileDescriptorWatcher Add FileDescriptorWatcher to esim_qmi_impl to pick up response messages from the eSIM chip. BUG=b:80591752 BUG=chromium:847619 TEST=FEATURES=test emerge-cheza hermes Change-Id: I67363b3339fee1b97ba3bcc142abc956d076bf7c Reviewed-on: https://chromium-review.googlesource.com/1134583 Commit-Ready: Jacob Rutherford <jruthe@google.com> Tested-by: Ben Chan <benchan@chromium.org> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/35147441fb68e5a8b9d41c853280f24554f1a3ca/hermes/main.cc [modify] https://crrev.com/35147441fb68e5a8b9d41c853280f24554f1a3ca/hermes/esim_qmi_impl.cc [modify] https://crrev.com/35147441fb68e5a8b9d41c853280f24554f1a3ca/hermes/esim_qmi_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c9d15b75e05b7b80bf17d839e0cbaf1b325bc32a commit c9d15b75e05b7b80bf17d839e0cbaf1b325bc32a Author: Jacob Rutherford <jruthe@chromium.org> Date: Thu Jul 26 02:45:34 2018 hermes: Add Lpd::Initialize Intialize the Esim class, i.e. get the node and port number for the UIM service. This event happens asynchronously after the qrtr_new_lookup command is issued, and a QRTR_NEW_SERVER response is received with the UIM service number. Once the node and port have been saved, other requests can be sent to the eSIM chip such as OPEN_LOGICAL_CHANNEL or RESET. BUG=b:80591752 BUG=chromium:847619 TEST=emerge-cheza hermes Change-Id: I987863f78476b4bf00e70c91c92c5d4c2ca11ca9 Reviewed-on: https://chromium-review.googlesource.com/1142830 Commit-Ready: Jacob Rutherford <jruthe@google.com> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Prashant Malani <pmalani@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/c9d15b75e05b7b80bf17d839e0cbaf1b325bc32a/hermes/esim.h [modify] https://crrev.com/c9d15b75e05b7b80bf17d839e0cbaf1b325bc32a/hermes/lpd.h [modify] https://crrev.com/c9d15b75e05b7b80bf17d839e0cbaf1b325bc32a/hermes/qmi_constants.h [modify] https://crrev.com/c9d15b75e05b7b80bf17d839e0cbaf1b325bc32a/hermes/esim_qmi_impl.cc [modify] https://crrev.com/c9d15b75e05b7b80bf17d839e0cbaf1b325bc32a/hermes/esim_qmi_impl.h [modify] https://crrev.com/c9d15b75e05b7b80bf17d839e0cbaf1b325bc32a/hermes/main.cc [modify] https://crrev.com/c9d15b75e05b7b80bf17d839e0cbaf1b325bc32a/hermes/lpd.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/2bc3fac8c5c37127a738ad3d9455da7a7844207e commit 2bc3fac8c5c37127a738ad3d9455da7a7844207e Author: Jacob Rutherford <jruthe@chromium.org> Date: Fri Jul 27 03:45:01 2018 hermes: Rename smdp class sed '{ s/SmdpFiImpl/SmdpImpl/g }' -i * sed '{ s/smdp_fi_impl/smdp_impl/g }' -i * BUG=b:80591752 BUG=chromium:847619 TEST=None Change-Id: I95d2a10b9e1d90f5cfc55e6904b1a67114ed2650 Reviewed-on: https://chromium-review.googlesource.com/1148594 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/2bc3fac8c5c37127a738ad3d9455da7a7844207e/hermes/main.cc [rename] https://crrev.com/2bc3fac8c5c37127a738ad3d9455da7a7844207e/hermes/smdp_unittest.cc [modify] https://crrev.com/2bc3fac8c5c37127a738ad3d9455da7a7844207e/hermes/hermes.gyp [rename] https://crrev.com/2bc3fac8c5c37127a738ad3d9455da7a7844207e/hermes/smdp_impl.cc [rename] https://crrev.com/2bc3fac8c5c37127a738ad3d9455da7a7844207e/hermes/smdp_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/68ed93d7dfd375c971f2413d2ff5ae0f5de8e829 commit 68ed93d7dfd375c971f2413d2ff5ae0f5de8e829 Author: Jacob Rutherford <jruthe@chromium.org> Date: Tue Jul 31 23:37:11 2018 hermes: Add transaction handling Add three functions that will directly handle interations with the eSIM. InitiateTransaction will send bytes to the chip, and keep a map of transaction numbers to callbacks to run once the eSIM responds with a matching transaction number. FinalizeTransaction will be the recipient of the received packets from the eSIM, in particular the bytes received from OnFileCanReadWithoutBlocking. If the eSIM signals that there are more bytes, ContinueTransaction will be called to handle the remaining packets. BUG=b:80591752 BUG=chromium:847619 TEST=FEATURES=test emerge-cheza hermes Change-Id: I04c6ce04a14a1b3da6b0618aa4996b8a47bacaff Reviewed-on: https://chromium-review.googlesource.com/1134584 Commit-Ready: Jacob Rutherford <jruthe@google.com> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/68ed93d7dfd375c971f2413d2ff5ae0f5de8e829/hermes/qmi_constants.h [modify] https://crrev.com/68ed93d7dfd375c971f2413d2ff5ae0f5de8e829/hermes/lpd.cc [modify] https://crrev.com/68ed93d7dfd375c971f2413d2ff5ae0f5de8e829/hermes/esim_qmi_impl.cc [modify] https://crrev.com/68ed93d7dfd375c971f2413d2ff5ae0f5de8e829/hermes/esim_qmi_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/9319cff6a528fe6cccba33235a033379675e4e28 commit 9319cff6a528fe6cccba33235a033379675e4e28 Author: Jacob Rutherford <jruthe@chromium.org> Date: Thu Aug 02 20:52:50 2018 hermes: fix misnamed variable forgot to update this variable when TransactionCallback struct was added in CL:1134584 BUG=b:80591752 BUG=chromium:847619 TEST=emerge-cheza hermes Change-Id: Ib8e9e56837bcc04f99aeb27c3044de86591ca7c2 Reviewed-on: https://chromium-review.googlesource.com/1159728 Commit-Ready: Jacob Rutherford <jruthe@google.com> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/9319cff6a528fe6cccba33235a033379675e4e28/hermes/esim_qmi_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/fc3002d2a3db5a99d39c86f9bcbe52c86e642063 commit fc3002d2a3db5a99d39c86f9bcbe52c86e642063 Author: Jacob Rutherford <jruthe@chromium.org> Date: Thu Aug 02 20:52:51 2018 hermes: Remove DataBlob The DataBlob alias for std::vector<uint8_t> ended up being more confusing than useful especially since it mainly makes use of the std::vector API. BUG=b:80591752 BUG=chromium:847619 TEST=emerge-cheza hermes Change-Id: I622c5b799dfa2b953a134385a88851cb713a4cf4 Reviewed-on: https://chromium-review.googlesource.com/1159729 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/fc3002d2a3db5a99d39c86f9bcbe52c86e642063/hermes/esim.h [modify] https://crrev.com/fc3002d2a3db5a99d39c86f9bcbe52c86e642063/hermes/esim_qmi_unittest.cc [modify] https://crrev.com/fc3002d2a3db5a99d39c86f9bcbe52c86e642063/hermes/esim_qmi_impl.cc [modify] https://crrev.com/fc3002d2a3db5a99d39c86f9bcbe52c86e642063/hermes/esim_qmi_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/61e18adbe2da3541b61d276c068fd10ea232dded commit 61e18adbe2da3541b61d276c068fd10ea232dded Author: Jacob Rutherford <jruthe@chromium.org> Date: Thu Aug 02 20:52:51 2018 hermes: fix testing compilation errors A few accumulated compilation errors as things have changed in the main code. This should compile. I'll work on this in the near future. BUG=b:80591752 BUG=chromium:847619 TEST=FEATURES=test emerge-cheza hermes Change-Id: I294614a40cfadde32af4c5df122a5103e9af3772 Reviewed-on: https://chromium-review.googlesource.com/1159736 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/61e18adbe2da3541b61d276c068fd10ea232dded/hermes/esim_qmi_unittest.cc [modify] https://crrev.com/61e18adbe2da3541b61d276c068fd10ea232dded/hermes/hermes.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/3eef1768ea2bd480cf3973629c06831ef3dd99de commit 3eef1768ea2bd480cf3973629c06831ef3dd99de Author: Jacob Rutherford <jruthe@chromium.org> Date: Wed Aug 08 20:45:50 2018 hermes: actually use kEsimChallengeTag Construct APDU request using the constant defined rather than ignoring it and hardcoding the value BUG=b:80591752 BUG=chromium:847619 TEST=emerge-cheza hermes Change-Id: I6e47f89e4e8420d0fc76714934800d78a95b3d77 Reviewed-on: https://chromium-review.googlesource.com/1163806 Commit-Ready: Jacob Rutherford <jruthe@google.com> Tested-by: Jacob Rutherford <jruthe@google.com> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/3eef1768ea2bd480cf3973629c06831ef3dd99de/hermes/esim_qmi_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/3fed6d64e70f243cde4de980e582272394fe3b00 commit 3fed6d64e70f243cde4de980e582272394fe3b00 Author: Jacob Rutherford <jruthe@chromium.org> Date: Thu Aug 23 14:37:17 2018 hermes: Add SM-DP+ Implementation Add basic functionality to the Smdp interface and the SmdpImpl class by forwarding the information received from the eSIM chip to the SM-DP+ server. The information is encoded as base64 strings and stored in a JSON dictionary to be written to the http packet that is sent to the server. BUG=b:80591752 BUG=chromium:847619 TEST=emerge-cheza hermes Change-Id: I7c4e82b2a5aa2eaaf397ba0818ecb79935049c60 Reviewed-on: https://chromium-review.googlesource.com/1148595 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/3fed6d64e70f243cde4de980e582272394fe3b00/hermes/lpd.h [modify] https://crrev.com/3fed6d64e70f243cde4de980e582272394fe3b00/hermes/hermes.gyp [modify] https://crrev.com/3fed6d64e70f243cde4de980e582272394fe3b00/hermes/esim_qmi_impl.cc [modify] https://crrev.com/3fed6d64e70f243cde4de980e582272394fe3b00/hermes/smdp_impl.h [modify] https://crrev.com/3fed6d64e70f243cde4de980e582272394fe3b00/hermes/main.cc [modify] https://crrev.com/3fed6d64e70f243cde4de980e582272394fe3b00/hermes/smdp.h [modify] https://crrev.com/3fed6d64e70f243cde4de980e582272394fe3b00/hermes/lpd.cc [modify] https://crrev.com/3fed6d64e70f243cde4de980e582272394fe3b00/hermes/smdp_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/1a956ef00c23f22dba831c1a5f6aed7bdd2678ea commit 1a956ef00c23f22dba831c1a5f6aed7bdd2678ea Author: Jacob Rutherford <jruthe@chromium.org> Date: Sun Sep 02 01:33:50 2018 hermes: Add AuthenticateServer functionality Adds functionality of EsimQmiImpl::AuthenticateServer, this includes fragmenting the data returned from Smdp::InitiateAuthentication into several packets that can be sent to the eSIM hardware through multiple EsimQmiImpl::SendApdu calls. BUG=b:80591752 BUG=chromium:847619 TEST=emerge-cheza hermes Change-Id: Ib3d59f2f5a85870754baf15502e98da576757987 Reviewed-on: https://chromium-review.googlesource.com/1159731 Commit-Ready: Alex Khouderchah <akhouderchah@chromium.org> Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Alex Khouderchah <akhouderchah@chromium.org> [modify] https://crrev.com/1a956ef00c23f22dba831c1a5f6aed7bdd2678ea/hermes/esim.h [modify] https://crrev.com/1a956ef00c23f22dba831c1a5f6aed7bdd2678ea/hermes/lpd.h [modify] https://crrev.com/1a956ef00c23f22dba831c1a5f6aed7bdd2678ea/hermes/esim_qmi_test.cc [modify] https://crrev.com/1a956ef00c23f22dba831c1a5f6aed7bdd2678ea/hermes/qmi_constants.h [modify] https://crrev.com/1a956ef00c23f22dba831c1a5f6aed7bdd2678ea/hermes/qmi_uim.h [modify] https://crrev.com/1a956ef00c23f22dba831c1a5f6aed7bdd2678ea/hermes/esim_qmi_impl.cc [modify] https://crrev.com/1a956ef00c23f22dba831c1a5f6aed7bdd2678ea/hermes/esim_qmi_impl.h [modify] https://crrev.com/1a956ef00c23f22dba831c1a5f6aed7bdd2678ea/hermes/smdp_test.cc [modify] https://crrev.com/1a956ef00c23f22dba831c1a5f6aed7bdd2678ea/hermes/main.cc [modify] https://crrev.com/1a956ef00c23f22dba831c1a5f6aed7bdd2678ea/hermes/smdp.h [modify] https://crrev.com/1a956ef00c23f22dba831c1a5f6aed7bdd2678ea/hermes/lpd.cc [modify] https://crrev.com/1a956ef00c23f22dba831c1a5f6aed7bdd2678ea/hermes/smdp_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/fe05fb0d8ce5b687f0a147be9de3ae31c7d3e61d commit fe05fb0d8ce5b687f0a147be9de3ae31c7d3e61d Author: Jacob Rutherford <jruthe@chromium.org> Date: Wed Sep 05 23:11:18 2018 hermes: Add Smdp::AuthenticateClient Adds AuthenticateClient functionality to the Smdp interface and the SmdpImpl class. BUG=b:80591752 BUG=chromium:847619 TEST=emerge-cheza hermes Change-Id: I367a372d0bef6c49cb61987aec7da52f464821ea Reviewed-on: https://chromium-review.googlesource.com/1159732 Commit-Ready: Alex Khouderchah <akhouderchah@chromium.org> Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Alex Khouderchah <akhouderchah@chromium.org> [modify] https://crrev.com/fe05fb0d8ce5b687f0a147be9de3ae31c7d3e61d/hermes/lpd.h [modify] https://crrev.com/fe05fb0d8ce5b687f0a147be9de3ae31c7d3e61d/hermes/esim_qmi_impl.h [modify] https://crrev.com/fe05fb0d8ce5b687f0a147be9de3ae31c7d3e61d/hermes/smdp_test.cc [modify] https://crrev.com/fe05fb0d8ce5b687f0a147be9de3ae31c7d3e61d/hermes/smdp_impl.h [modify] https://crrev.com/fe05fb0d8ce5b687f0a147be9de3ae31c7d3e61d/hermes/smdp.h [modify] https://crrev.com/fe05fb0d8ce5b687f0a147be9de3ae31c7d3e61d/hermes/lpd.cc [modify] https://crrev.com/fe05fb0d8ce5b687f0a147be9de3ae31c7d3e61d/hermes/smdp_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/79625d3c4cf1f891bfe8b7e9ceed459cbe954c3d commit 79625d3c4cf1f891bfe8b7e9ceed459cbe954c3d Author: Jacob Rutherford <jruthe@chromium.org> Date: Sat Sep 08 05:27:31 2018 hermes: Update logging Overhaul of logs that are output from Hermes, VLOGS can mostly be enabled by using command line switch --log_level=-1 BUG=b:80591752 BUG=chromium:847619 TEST=emerge-cheza hermes Change-Id: Ic95455980e88ddd0578d2723f84d44a74998161f Reviewed-on: https://chromium-review.googlesource.com/1163805 Commit-Ready: Alex Khouderchah <akhouderchah@chromium.org> Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Alex Khouderchah <akhouderchah@chromium.org> [modify] https://crrev.com/79625d3c4cf1f891bfe8b7e9ceed459cbe954c3d/hermes/lpd.h [modify] https://crrev.com/79625d3c4cf1f891bfe8b7e9ceed459cbe954c3d/hermes/esim_qmi_impl.cc [modify] https://crrev.com/79625d3c4cf1f891bfe8b7e9ceed459cbe954c3d/hermes/smdp_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/5b04ca819e723e555d430008ad0f4a4b8da6b476 commit 5b04ca819e723e555d430008ad0f4a4b8da6b476 Author: Jacob Rutherford <jruthe@chromium.org> Date: Sat Sep 08 05:27:31 2018 hermes: Update Lpd::.* function parameters Previously, the base::Closure supplied by the user was both saved in a private member variable |user_success_| and also passed as a parameter to every callback we registered with the Esim interface. This didn't make a lot of sense, so I removed the function parameter and kept the private member variable. BUG=b:80591752 BUG=chromium:847619 TEST=emerge-cheza hermes Change-Id: I22944b8894213823de51dc760bfa5cc4cf70b3cb Reviewed-on: https://chromium-review.googlesource.com/1171346 Commit-Ready: Alex Khouderchah <akhouderchah@chromium.org> Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Alex Khouderchah <akhouderchah@chromium.org> [modify] https://crrev.com/5b04ca819e723e555d430008ad0f4a4b8da6b476/hermes/lpd.h [modify] https://crrev.com/5b04ca819e723e555d430008ad0f4a4b8da6b476/hermes/lpd.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e53995617f106427a6110c8997eddc2520889542 commit e53995617f106427a6110c8997eddc2520889542 Author: Jacob Rutherford <jruthe@chromium.org> Date: Mon Sep 10 08:13:24 2018 hermes: Add DownloadProfile flow to Lpd On completion of Lpd::Authenticate, the Download procedure can begin. As specified in SGP.22 3.1.3, this procedure will have the following flow: Esim::PrepareDownload -> Smdp::GetBoundProfilePackage which will be followed by profile installation. On the completion of Lpd::Authenticate procedure, Lpd must perform checks against the Rules Authorization Table of the eSIM chip, as well as performing checks against the PPR provided by the server, if any, against the Profiles Info of the eSIM. BUG=b:80591752 BUG=chromium:847619 TEST=emerge-cheza hermes Change-Id: Iac30aeefd35f3383e43d9c9e852afb093c2a0d86 Reviewed-on: https://chromium-review.googlesource.com/1171343 Commit-Ready: Alex Khouderchah <akhouderchah@chromium.org> Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Alex Khouderchah <akhouderchah@chromium.org> [modify] https://crrev.com/e53995617f106427a6110c8997eddc2520889542/hermes/esim.h [modify] https://crrev.com/e53995617f106427a6110c8997eddc2520889542/hermes/lpd.h [modify] https://crrev.com/e53995617f106427a6110c8997eddc2520889542/hermes/qmi_constants.h [modify] https://crrev.com/e53995617f106427a6110c8997eddc2520889542/hermes/esim_qmi_impl.cc [modify] https://crrev.com/e53995617f106427a6110c8997eddc2520889542/hermes/esim_qmi_impl.h [modify] https://crrev.com/e53995617f106427a6110c8997eddc2520889542/hermes/smdp_test.cc [modify] https://crrev.com/e53995617f106427a6110c8997eddc2520889542/hermes/smdp_impl.h [modify] https://crrev.com/e53995617f106427a6110c8997eddc2520889542/hermes/smdp.h [modify] https://crrev.com/e53995617f106427a6110c8997eddc2520889542/hermes/lpd.cc [modify] https://crrev.com/e53995617f106427a6110c8997eddc2520889542/hermes/smdp_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/66ae20890a7db595c51d582ec181dd74e86b3954 commit 66ae20890a7db595c51d582ec181dd74e86b3954 Author: Jacob Rutherford <jruthe@chromium.org> Date: Fri Sep 14 01:58:55 2018 hermes: Add PrepareDownloadRequest and GetBoundProfilePackage Add two functions to continue the flow of the InstallProfile sequence. PrepareDownloadRequest uses the response data from the final call of the Common Mutual Authentication Procedure to get prepare the eSIM for the download and installation of a new profile. BUG=b:80591752 BUG=chromium:847619 TEST=emerge-cheza hermes Change-Id: Ia8f8e691973ac436efec0a16d6aee11bfdab3daf Reviewed-on: https://chromium-review.googlesource.com/1171344 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Alex Khouderchah <akhouderchah@chromium.org> [modify] https://crrev.com/66ae20890a7db595c51d582ec181dd74e86b3954/hermes/lpd.h [modify] https://crrev.com/66ae20890a7db595c51d582ec181dd74e86b3954/hermes/smdp.h [modify] https://crrev.com/66ae20890a7db595c51d582ec181dd74e86b3954/hermes/lpd.cc [modify] https://crrev.com/66ae20890a7db595c51d582ec181dd74e86b3954/hermes/smdp_impl.cc [modify] https://crrev.com/66ae20890a7db595c51d582ec181dd74e86b3954/hermes/smdp_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d9b24525b4e5e0497310931c4ffbd18f6147105c commit d9b24525b4e5e0497310931c4ffbd18f6147105c Author: Jacob Rutherford <jruthe@chromium.org> Date: Sat Sep 15 23:21:50 2018 hermes: Add LoadBoundProfilePackage LoadBoundProfilePackage loads a profile to the eSIM chip after being downloaded from the SM-DP+ server. BUG=b:80591752 BUG=chromium:847619 TEST=emerge-cheza hermes Change-Id: I86ad5371f7a4739d0d949b8545fd793a2bd49067 Reviewed-on: https://chromium-review.googlesource.com/1171345 Commit-Ready: Alex Khouderchah <akhouderchah@chromium.org> Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Alex Khouderchah <akhouderchah@chromium.org> [modify] https://crrev.com/d9b24525b4e5e0497310931c4ffbd18f6147105c/hermes/esim.h [modify] https://crrev.com/d9b24525b4e5e0497310931c4ffbd18f6147105c/hermes/lpd.h [modify] https://crrev.com/d9b24525b4e5e0497310931c4ffbd18f6147105c/hermes/lpd.cc [modify] https://crrev.com/d9b24525b4e5e0497310931c4ffbd18f6147105c/hermes/esim_qmi_impl.cc [modify] https://crrev.com/d9b24525b4e5e0497310931c4ffbd18f6147105c/hermes/esim_qmi_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/abdf4c8ee62eb76f01ed5b2d2bc6da52e6898de5 commit abdf4c8ee62eb76f01ed5b2d2bc6da52e6898de5 Author: Alex Khouderchah <akhouderchah@chromium.org> Date: Mon Oct 01 18:31:11 2018 hermes: Change interface naming scheme and remove esim interface This CL changes the naming scheme of classes, such that interface classes have the suffix 'Interface', rather than having implementation classes use the suffix 'Impl*'. This is done for consistency, as classes that do not use an interface don't use the 'Impl*' suffix, making it hard to tell from a class name whether it is an implementation class or an interface class. The esim interface class is also removed, as there is only one esim implementation. A future CL separates modem-specific functionality from the esim implementation, making it unnecessary to create more esim implementations. Instead, supporting new modems will simply involve creating a new modem implementation. BUG=chromium:847619 TEST=`cros_workon_make --board ${BOARD} hermes --test` builds successfully. Note that the unit tests still do not pass. This will be changed after the Esim implementation is isolated from QRTR-specific functionality, as unit-testing the resulting Esim implementation will be easier. Change-Id: I9412ae7cf0319d160dd4f301e33247b913bb2902 Reviewed-on: https://chromium-review.googlesource.com/1199596 Commit-Ready: Alex Khouderchah <akhouderchah@chromium.org> Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/abdf4c8ee62eb76f01ed5b2d2bc6da52e6898de5/hermes/esim.h [delete] https://crrev.com/cedea6205fe61747977cda10298f5dd4e6f6e796/hermes/esim_qmi_test.cc [add] https://crrev.com/abdf4c8ee62eb76f01ed5b2d2bc6da52e6898de5/hermes/esim_test.cc [add] https://crrev.com/abdf4c8ee62eb76f01ed5b2d2bc6da52e6898de5/hermes/smdp_interface.h [delete] https://crrev.com/cedea6205fe61747977cda10298f5dd4e6f6e796/hermes/esim_qmi_impl.h [modify] https://crrev.com/abdf4c8ee62eb76f01ed5b2d2bc6da52e6898de5/hermes/smdp_test.cc [delete] https://crrev.com/cedea6205fe61747977cda10298f5dd4e6f6e796/hermes/smdp_impl.h [modify] https://crrev.com/abdf4c8ee62eb76f01ed5b2d2bc6da52e6898de5/hermes/BUILD.gn [modify] https://crrev.com/abdf4c8ee62eb76f01ed5b2d2bc6da52e6898de5/hermes/main.cc [rename] https://crrev.com/abdf4c8ee62eb76f01ed5b2d2bc6da52e6898de5/hermes/smdp.cc [modify] https://crrev.com/abdf4c8ee62eb76f01ed5b2d2bc6da52e6898de5/hermes/smdp.h [rename] https://crrev.com/abdf4c8ee62eb76f01ed5b2d2bc6da52e6898de5/hermes/esim.cc
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/866fa5c716d17b9ef42b0c81122ffbde77b3aeb0 commit 866fa5c716d17b9ef42b0c81122ffbde77b3aeb0 Author: Alex Khouderchah <akhouderchah@chromium.org> Date: Wed Nov 21 13:53:01 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/cc7c60ca7b2a2232f66357bf1d536e541c8a716b commit cc7c60ca7b2a2232f66357bf1d536e541c8a716b Author: Alex Khouderchah <akhouderchah@chromium.org> Date: Wed Dec 05 01:40:15 2018 dev-cpp/absl: Create ebuild for Absl The hermes project will be integrated with an internal library that requires absl in order to be built. As upstream Portage does not contain any ebuild for absl, we create one here. BUG=chromium:847619 TEST=`emerge-cheza absl` Change-Id: Icf726561203ce4279a853593cf1529b0ec5a5fd6 Reviewed-on: https://chromium-review.googlesource.com/1335668 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/cc7c60ca7b2a2232f66357bf1d536e541c8a716b/dev-cpp/absl/files/absl-0.0.1-cmake-install-headers.patch [add] https://crrev.com/cc7c60ca7b2a2232f66357bf1d536e541c8a716b/dev-cpp/absl/absl-20180600-r1.ebuild [add] https://crrev.com/cc7c60ca7b2a2232f66357bf1d536e541c8a716b/dev-cpp/absl/Manifest
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/platform/google-lpa/+/b0f7d0eb331aa1aa14d5157bfd91c5557812eb24 commit b0f7d0eb331aa1aa14d5157bfd91c5557812eb24 Author: Alex Khouderchah <akhouderchah@google.com> Date: Tue Dec 11 21:00:56 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/9aa203cb66d628058b43d0728bdb92dfceb2f1a7 commit 9aa203cb66d628058b43d0728bdb92dfceb2f1a7 Author: Alex Khouderchah <akhouderchah@chromium.org> Date: Tue Dec 11 21:00:57 2018 hermes: Create CommandApdu and ResponseApdu classes Future CLs separate the esim functionality between SGP.22-specific and modem-specific functionality. This allows for the use of hermes with different modems simply by creating a new modem implementation. The fragmentation of APDUs, however, is not functionality specific to any particular modem. This CL adds classes to represent command and response APDUs. The CommandApdu class takes care of functionality such as the creation of the in-memory structure of an APDU, and APDU fragmentation both for standard and extended-length APDUs. The ResponseApdu class encapsulates the reading of response status bytes. BUG=chromium:847619 TEST=- Manually tested with CL:1199598 and ensured that Bound Profile Package was successfully received. - All unit tests are passing. Change-Id: I2393528765f10a819bd6c94e4d58f74bbfde230f Reviewed-on: https://chromium-review.googlesource.com/1368640 Commit-Ready: Alex Khouderchah <akhouderchah@chromium.org> Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [add] https://crrev.com/9aa203cb66d628058b43d0728bdb92dfceb2f1a7/hermes/apdu_test.cc [add] https://crrev.com/9aa203cb66d628058b43d0728bdb92dfceb2f1a7/hermes/apdu.cc [add] https://crrev.com/9aa203cb66d628058b43d0728bdb92dfceb2f1a7/hermes/apdu.h [modify] https://crrev.com/9aa203cb66d628058b43d0728bdb92dfceb2f1a7/hermes/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/312770314bc01cd85745966a7326a75b24d5121a commit 312770314bc01cd85745966a7326a75b24d5121a Author: Alex Khouderchah <akhouderchah@chromium.org> Date: Sat Dec 15 06:40:28 2018 hermes: Move SGP.22-specific constants to sgp_22 files BUG=chromium:847619 TEST=None. Change-Id: I48b5f6fc6fb8c177aadc2ca4515fdee832303ad6 Reviewed-on: https://chromium-review.googlesource.com/1368642 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [add] https://crrev.com/312770314bc01cd85745966a7326a75b24d5121a/hermes/sgp_22.h [add] https://crrev.com/312770314bc01cd85745966a7326a75b24d5121a/hermes/sgp_22.cc [modify] https://crrev.com/312770314bc01cd85745966a7326a75b24d5121a/hermes/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/1861438613172ce7aea6665adf698d122aa4627c commit 1861438613172ce7aea6665adf698d122aa4627c Author: Alex Khouderchah <akhouderchah@chromium.org> Date: Tue Jan 08 09:59:13 2019 hermes: socket: Introduce socket interface This change introduces an abstraction of sockets used to communicate with modems, facilitating unit testing and insulating EuiccCard implementations from socket-specific details. BUG=chromium:847619 TEST=None. Change-Id: Ide16a6dae65b2db5add205c214842a4aa32c4c56 Reviewed-on: https://chromium-review.googlesource.com/1395785 Commit-Ready: Alex Khouderchah <akhouderchah@chromium.org> Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [add] https://crrev.com/1861438613172ce7aea6665adf698d122aa4627c/hermes/socket_qrtr.h [add] https://crrev.com/1861438613172ce7aea6665adf698d122aa4627c/hermes/socket_interface.h [add] https://crrev.com/1861438613172ce7aea6665adf698d122aa4627c/hermes/socket_qrtr.cc [modify] https://crrev.com/1861438613172ce7aea6665adf698d122aa4627c/hermes/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/586ef0af215a79bd8bb01afc4b98c222e0f099a5 commit 586ef0af215a79bd8bb01afc4b98c222e0f099a5 Author: Alex Khouderchah <akhouderchah@chromium.org> Date: Sat Jan 19 04:05:28 2019 eclass-overlay: Add hermes user and group BUG=chromium:847619 TEST=None Change-Id: Ice34cf16dea7737f10ce296461159769500488b1 Reviewed-on: https://chromium-review.googlesource.com/1409703 Commit-Ready: Alex Khouderchah <akhouderchah@chromium.org> Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [add] https://crrev.com/586ef0af215a79bd8bb01afc4b98c222e0f099a5/profiles/base/accounts/user/hermes [add] https://crrev.com/586ef0af215a79bd8bb01afc4b98c222e0f099a5/profiles/base/accounts/group/hermes
Comment 1 by bugdroid1@chromium.org
, Jun 8 2018